You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/18 13:05:45 UTC

[GitHub] [airflow] ashb opened a new pull request #19680: Fix incorrect DAG id in KubeExecutor tests

ashb opened a new pull request #19680:
URL: https://github.com/apache/airflow/pull/19680


   We had deleted the example_kubernetes_executor_config dag and put it all
   in the sinle example_kubernetes_executor, but the tests had been broken
   for a while that we didn't notice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb edited a comment on pull request #19680: Fix incorrect DAG id in KubeExecutor tests

Posted by GitBox <gi...@apache.org>.
ashb edited a comment on pull request #19680:
URL: https://github.com/apache/airflow/pull/19680#issuecomment-972851562


   Think we should merge this now, or wait for the migration fixes and see if there is anything else broken?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #19680: Fix incorrect DAG id in KubeExecutor tests

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #19680:
URL: https://github.com/apache/airflow/pull/19680#issuecomment-973046893


   omg green!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #19680: Fix incorrect DAG id in KubeExecutor tests

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19680:
URL: https://github.com/apache/airflow/pull/19680#issuecomment-972850748


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #19680: Fix incorrect DAG id in KubeExecutor tests

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #19680:
URL: https://github.com/apache/airflow/pull/19680#issuecomment-972851562


   Think we should merge this now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #19680: Fix incorrect DAG id in KubeExecutor tests

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19680:
URL: https://github.com/apache/airflow/pull/19680#issuecomment-973083641


   > omg green!
   
   :dancers: 
   
   But we also have some tests failing in main due to boto3 recent upgrade most likely - will try to fix them later today :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb closed pull request #19680: Fix incorrect DAG id in KubeExecutor tests

Posted by GitBox <gi...@apache.org>.
ashb closed pull request #19680:
URL: https://github.com/apache/airflow/pull/19680


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on pull request #19680: Fix incorrect DAG id in KubeExecutor tests

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #19680:
URL: https://github.com/apache/airflow/pull/19680#issuecomment-972860474


   probably wait for the migration fixes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb merged pull request #19680: Fix incorrect DAG id in KubeExecutor tests

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #19680:
URL: https://github.com/apache/airflow/pull/19680


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org