You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/12/11 05:06:34 UTC

[GitHub] [singa] chrishkchris opened a new pull request #822: Fix new lstm error

chrishkchris opened a new pull request #822:
URL: https://github.com/apache/singa/pull/822


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] joddiy merged pull request #822: Fix new lstm error

Posted by GitBox <gi...@apache.org>.
joddiy merged pull request #822:
URL: https://github.com/apache/singa/pull/822


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] edited a comment on pull request #822: Fix new lstm error

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #822:
URL: https://github.com/apache/singa/pull/822#issuecomment-742972886


   # [Codecov](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=h1) Report
   > Merging [#822](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=desc) (d89f2f8) into [master](https://codecov.io/gh/apache/singa/commit/1862c726389b5b254380ee99357c7a12ea658f28?el=desc) (1862c72) will **decrease** coverage by `1.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/822/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #822      +/-   ##
   ==========================================
   - Coverage   66.12%   65.09%   -1.04%     
   ==========================================
     Files          87       86       -1     
     Lines        5541     4804     -737     
   ==========================================
   - Hits         3664     3127     -537     
   + Misses       1877     1677     -200     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | singa-cpp | `65.09% <ø> (-1.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-3.80%)` | :arrow_down: |
   | [src/core/tensor/tensor\_math\_cpp.h](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvcl9tYXRoX2NwcC5o) | `66.05% <0.00%> (-3.61%)` | :arrow_down: |
   | [src/core/tensor/tensor.cc](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvci5jYw==) | `76.54% <0.00%> (-3.06%)` | :arrow_down: |
   | [src/utils/logging.cc](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-c3JjL3V0aWxzL2xvZ2dpbmcuY2M=) | `49.27% <0.00%> (-1.41%)` | :arrow_down: |
   | [include/half.hpp](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-aW5jbHVkZS9oYWxmLmhwcA==) | | |
   | [src/core/tensor/tensor\_math.h](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvcl9tYXRoLmg=) | `5.10% <0.00%> (+0.56%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=footer). Last update [1862c72...e6dfeda](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] edited a comment on pull request #822: Fix new lstm error

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #822:
URL: https://github.com/apache/singa/pull/822#issuecomment-742972886


   # [Codecov](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=h1) Report
   > Merging [#822](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=desc) (e6dfeda) into [master](https://codecov.io/gh/apache/singa/commit/1862c726389b5b254380ee99357c7a12ea658f28?el=desc) (1862c72) will **decrease** coverage by `1.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/822/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #822      +/-   ##
   ==========================================
   - Coverage   66.12%   65.09%   -1.04%     
   ==========================================
     Files          87       86       -1     
     Lines        5541     4804     -737     
   ==========================================
   - Hits         3664     3127     -537     
   + Misses       1877     1677     -200     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | singa-cpp | `65.09% <ø> (-1.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-3.80%)` | :arrow_down: |
   | [src/core/tensor/tensor\_math\_cpp.h](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvcl9tYXRoX2NwcC5o) | `66.05% <0.00%> (-3.61%)` | :arrow_down: |
   | [src/core/tensor/tensor.cc](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvci5jYw==) | `76.54% <0.00%> (-3.06%)` | :arrow_down: |
   | [src/utils/logging.cc](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-c3JjL3V0aWxzL2xvZ2dpbmcuY2M=) | `49.27% <0.00%> (-1.41%)` | :arrow_down: |
   | [include/half.hpp](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-aW5jbHVkZS9oYWxmLmhwcA==) | | |
   | [src/core/tensor/tensor\_math.h](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvcl9tYXRoLmg=) | `5.10% <0.00%> (+0.56%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=footer). Last update [1862c72...e6dfeda](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] lgtm-com[bot] commented on pull request #822: Fix new lstm error

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #822:
URL: https://github.com/apache/singa/pull/822#issuecomment-742983134


   This pull request **fixes 1 alert** when merging e6dfeda57a691500ae83681b5f605bec788eed63 into 1862c726389b5b254380ee99357c7a12ea658f28 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-287a91598efa59c4a74755d39565b83aabfaf057)
   
   **fixed alerts:**
   
   * 1 for Wrong number of arguments in a call


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [singa] codecov[bot] commented on pull request #822: Fix new lstm error

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #822:
URL: https://github.com/apache/singa/pull/822#issuecomment-742972886


   # [Codecov](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=h1) Report
   > Merging [#822](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=desc) (d89f2f8) into [master](https://codecov.io/gh/apache/singa/commit/1862c726389b5b254380ee99357c7a12ea658f28?el=desc) (1862c72) will **decrease** coverage by `1.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/822/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #822      +/-   ##
   ==========================================
   - Coverage   66.12%   65.09%   -1.04%     
   ==========================================
     Files          87       86       -1     
     Lines        5541     4804     -737     
   ==========================================
   - Hits         3664     3127     -537     
   + Misses       1877     1677     -200     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | singa-cpp | `65.09% <ø> (-1.04%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-3.80%)` | :arrow_down: |
   | [src/core/tensor/tensor\_math\_cpp.h](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvcl9tYXRoX2NwcC5o) | `66.05% <0.00%> (-3.61%)` | :arrow_down: |
   | [src/core/tensor/tensor.cc](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvci5jYw==) | `76.54% <0.00%> (-3.06%)` | :arrow_down: |
   | [src/utils/logging.cc](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-c3JjL3V0aWxzL2xvZ2dpbmcuY2M=) | `49.27% <0.00%> (-1.41%)` | :arrow_down: |
   | [include/half.hpp](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-aW5jbHVkZS9oYWxmLmhwcA==) | | |
   | [src/core/tensor/tensor\_math.h](https://codecov.io/gh/apache/singa/pull/822/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvcl9tYXRoLmg=) | `5.10% <0.00%> (+0.56%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=footer). Last update [1862c72...d89f2f8](https://codecov.io/gh/apache/singa/pull/822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org