[GitHub] [helix] NealSun96 commented on a change in pull request #1579: Task Current State Migration: helix-rest, utils, tests changes

[GitBox <gi...@apache.org>]

NealSun96 commented on a change in pull request #1579:
URL: https://github.com/apache/helix/pull/1579#discussion_r540591644



##########
File path: helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java
##########
@@ -188,11 +187,7 @@ public static boolean hasErrorPartitions(HelixDataAccessor dataAccessor, String
     if (liveInstance != null) {
       String sessionId = liveInstance.getEphemeralOwner();
 
-      PropertyKey currentStatesKey = propertyKeyBuilder.currentStates(instanceName, sessionId);
-      List<String> resourceNames = dataAccessor.getChildNames(currentStatesKey);
-      for (String resourceName : resourceNames) {
-        PropertyKey key = propertyKeyBuilder.currentState(instanceName, sessionId, resourceName);
-
+      for (PropertyKey key : getAllCurrentStateKeys(dataAccessor, instanceName, sessionId)) {

Review comment:
       @dasahcc removed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org