[GitHub] [apisix-dashboard] ctubbsii commented on pull request #356: Feat release 1.5

[GitBox <gi...@apache.org>]

ctubbsii commented on pull request #356:
URL: https://github.com/apache/apisix-dashboard/pull/356#issuecomment-667647301


   > > @juzhiyuan please avoid pinging all the apache committers (you've pinged 3k+ people)
   > 
   > Oh no.. I meant to ping only apisix's committers..
   
   Hi @juzhiyuan . I'm not a committer on this project, but received the notification along with the other people throughout Apache, and wanted to offer a few friendly tips:
   
   You never need to ping *any* GitHub teams on a PR. That forces a notification to everybody on that team who has linked their GitHub account to their Apache committer account, even if they've specifically elected to *not* receive notifications for activity on the repository. Those teams are primarily used internally for permissions management, and are not the best way to get the developers' attention.
   
   Mentioning a team is also redundant. If somebody has chosen to watch the repository, then they would have received a notification of the new PR anyway, because they have subscribed to those notifications. No additional mention is necessary to trigger a notification.
   
   In addition, the developer teams would have also received an email notification for new pull requests on their notification list, such as [this one](https://lists.apache.org/thread.html/r2520c135669659f92a155cbd74c8f528856336f6aa96406015b31b5b%40%3Cnotifications.apisix.apache.org%3E).
   
   If you open a pull request and don't hear anything from the developers in a reasonable time, the best practice is probably to try to simply comment on the pull request or reach out to their developer mailing list instead (usually `dev@<project>.apache.org`), to request their attention.
   
   People make mistakes. I'm sure it's not a huge problem, but I hope these tips help in future.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org