You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/27 03:38:08 UTC
[GitHub] [doris] AshinGau opened a new pull request, #10435: [feature-wip](multi-catalog) get catalog name from TableName
AshinGau opened a new pull request, #10435:
URL: https://github.com/apache/doris/pull/10435
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Get catalog name from TableName.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #10435: [feature-wip](multi-catalog) get catalog name from TableName
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10435:
URL: https://github.com/apache/doris/pull/10435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #10435: [feature-wip](multi-catalog) get catalog name from TableName
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #10435:
URL: https://github.com/apache/doris/pull/10435#discussion_r906954741
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/TableName.java:
##########
@@ -76,6 +77,10 @@ public void analyze(Analyzer analyzer) throws AnalysisException {
ctl = InternalDataSource.INTERNAL_DS_NAME;
}
}
+ if (!ctl.equals(InternalDataSource.INTERNAL_DS_NAME)) {
+ Util.checkCatalogEnabled();
+ analyzer.validateCatalog(ctl);
Review Comment:
We don't check if catalog exist in this phase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org