You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Prakash Khemani (Created) (JIRA)" <ji...@apache.org> on 2011/12/07 02:34:40 UTC
[jira] [Created] (HBASE-4969) tautology in HRegionInfo.readFields
tautology in HRegionInfo.readFields
-----------------------------------
Key: HBASE-4969
URL: https://issues.apache.org/jira/browse/HBASE-4969
Project: HBase
Issue Type: Bug
Reporter: Prakash Khemani
Assignee: Prakash Khemani
In HRegionInfo.readFields() the following looks wrong to me
} else if (getVersion() == VERSION) {
it is always true.
Should it have been
} else if (getVersion() == version) {
version is a local variable where the deserialized-version is stored.
(I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4969) tautology in HRegionInfo.readFields
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165482#comment-13165482 ]
Phabricator commented on HBASE-4969:
------------------------------------
stack has commented on the revision "HBASE-4969 [jira] tautology in HRegionInfo.readFields".
@Nicolas
That made a big difference (I'll doc this in our book after I get it to work). After installing cert which the tool guided me through nicely, I got to this:
Exception:
ERR-CONDUIT-CORE: Bogus ID provided to load().
(Run with --trace for a full exception trace.)
h-24-30:hbase stack$ arc amend --trace --revision D669
Loading phutil library 'arclib' from '/Users/Stack/checkouts/hbase/.arc_jira_lib'...
>>> [0] <conduit> conduit.connect()
<<< [0] <conduit> 418,950 us
>>> [1] <exec> $ (cd '/Users/Stack/checkouts/hbase'; git rev-parse --show-cdup)
<<< [1] <exec> 10,368 us
>>> [2] <exec> $ (cd '/Users/Stack/checkouts/hbase/'; git rev-parse --verify HEAD^)
<<< [2] <exec> 15,268 us
>>> [3] <exec> $ (cd '/Users/Stack/checkouts/hbase/'; git diff --no-ext-diff --no-textconv --raw 'HEAD^' --)
>>> [4] <exec> $ (cd '/Users/Stack/checkouts/hbase/'; git diff --no-ext-diff --no-textconv --raw HEAD --)
>>> [5] <exec> $ (cd '/Users/Stack/checkouts/hbase/'; git ls-files --others --exclude-standard)
>>> [6] <exec> $ (cd '/Users/Stack/checkouts/hbase/'; git ls-files -m)
<<< [6] <exec> 62,638 us
<<< [3] <exec> 67,122 us
<<< [5] <exec> 65,706 us
<<< [4] <exec> 75,585 us
>>> [7] <conduit> differential.getcommitmessage()
Fatal error: Uncaught exception 'ConduitClientException' with message 'ERR-CONDUIT-CORE: Bogus ID provided to load().' in /Users/Stack/checkouts/libphutil/src/conduit/client/ConduitFuture.php:54
Stack trace:
#0 /Users/Stack/checkouts/libphutil/src/future/proxy/FutureProxy.php(62): ConduitFuture->didReceiveResult(Array)
#1 /Users/Stack/checkouts/libphutil/src/future/proxy/FutureProxy.php(39): FutureProxy->getResult()
#2 /Users/Stack/checkouts/libphutil/src/conduit/client/ConduitClient.php(52): FutureProxy->resolve()
#3 /Users/Stack/checkouts/arcanist/src/workflow/amend/ArcanistAmendWorkflow.php(125): ConduitClient->callMethodSynchronous('differential.ge...', Array)
#4 /Users/Stack/checkouts/arcanist/scripts/arcanist.php(257): ArcanistAmendWorkflow->run()
#5 {main}
thrown in /Users/Stack/checkouts/libphutil/src/conduit/client/ConduitFuture.php on line 54
REVISION DETAIL
https://reviews.facebook.net/D669
> tautology in HRegionInfo.readFields
> -----------------------------------
>
> Key: HBASE-4969
> URL: https://issues.apache.org/jira/browse/HBASE-4969
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
> } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
> } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4969) tautology in HRegionInfo.readFields
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166250#comment-13166250 ]
Hudson commented on HBASE-4969:
-------------------------------
Integrated in HBase-0.92 #180 (See [https://builds.apache.org/job/HBase-0.92/180/])
HBASE-4969 tautology in HRegionInfo.readFields
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
> tautology in HRegionInfo.readFields
> -----------------------------------
>
> Key: HBASE-4969
> URL: https://issues.apache.org/jira/browse/HBASE-4969
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.0
>
> Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
> } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
> } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4969) tautology in HRegionInfo.readFields
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198554#comment-13198554 ]
Phabricator commented on HBASE-4969:
------------------------------------
dhruba has resigned from the revision "HBASE-4969 [jira] tautology in HRegionInfo.readFields".
REVISION DETAIL
https://reviews.facebook.net/D669
> tautology in HRegionInfo.readFields
> -----------------------------------
>
> Key: HBASE-4969
> URL: https://issues.apache.org/jira/browse/HBASE-4969
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.0
>
> Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
> } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
> } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4969) tautology in HRegionInfo.readFields
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4969:
-------------------------------
Attachment: HBASE-4969.D669.1.patch
khemani requested code review of "HBASE-4969 [jira] tautology in HRegionInfo.readFields".
Reviewers: nspiegelberg, dhruba, JIRA
as in title
TEST PLAN
minor change.
REVISION DETAIL
https://reviews.facebook.net/D669
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/1479/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> tautology in HRegionInfo.readFields
> -----------------------------------
>
> Key: HBASE-4969
> URL: https://issues.apache.org/jira/browse/HBASE-4969
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
> } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
> } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4969) tautology in HRegionInfo.readFields
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165451#comment-13165451 ]
Phabricator commented on HBASE-4969:
------------------------------------
stack has commented on the revision "HBASE-4969 [jira] tautology in HRegionInfo.readFields".
How I fix this Prakash?
h-24-30:trunk stack$ arc amend --revision D669
Usage Exception: Failed to load library "arclib" at location ".arc_jira_lib". Please check the "phutil_libraries" setting in your .arcconfig file. Refer to page http://phabricator.com/docs/arcanist/article/Setting_Up_.arcconfig.html for more info.
I'm trying to do what Mikhail asked me do,
REVISION DETAIL
https://reviews.facebook.net/D669
> tautology in HRegionInfo.readFields
> -----------------------------------
>
> Key: HBASE-4969
> URL: https://issues.apache.org/jira/browse/HBASE-4969
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
> } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
> } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4969) tautology in HRegionInfo.readFields
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166175#comment-13166175 ]
Hudson commented on HBASE-4969:
-------------------------------
Integrated in HBase-TRUNK-security #26 (See [https://builds.apache.org/job/HBase-TRUNK-security/26/])
HBASE-4969 tautology in HRegionInfo.readFields
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
> tautology in HRegionInfo.readFields
> -----------------------------------
>
> Key: HBASE-4969
> URL: https://issues.apache.org/jira/browse/HBASE-4969
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.0
>
> Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
> } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
> } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4969) tautology in HRegionInfo.readFields
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166079#comment-13166079 ]
Hudson commented on HBASE-4969:
-------------------------------
Integrated in HBase-0.92-security #34 (See [https://builds.apache.org/job/HBase-0.92-security/34/])
HBASE-4969 tautology in HRegionInfo.readFields
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
> tautology in HRegionInfo.readFields
> -----------------------------------
>
> Key: HBASE-4969
> URL: https://issues.apache.org/jira/browse/HBASE-4969
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.0
>
> Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
> } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
> } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4969) tautology in HRegionInfo.readFields
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165973#comment-13165973 ]
Hudson commented on HBASE-4969:
-------------------------------
Integrated in HBase-TRUNK #2532 (See [https://builds.apache.org/job/HBase-TRUNK/2532/])
HBASE-4969 tautology in HRegionInfo.readFields
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
> tautology in HRegionInfo.readFields
> -----------------------------------
>
> Key: HBASE-4969
> URL: https://issues.apache.org/jira/browse/HBASE-4969
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.0
>
> Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
> } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
> } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4969) tautology in HRegionInfo.readFields
Posted by "stack (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-4969.
--------------------------
Resolution: Fixed
Fix Version/s: 0.92.0
Hadoop Flags: Reviewed
Committed branch and trunk. Thanks for patch Prakash.
> tautology in HRegionInfo.readFields
> -----------------------------------
>
> Key: HBASE-4969
> URL: https://issues.apache.org/jira/browse/HBASE-4969
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Fix For: 0.92.0
>
> Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
> } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
> } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4969) tautology in HRegionInfo.readFields
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165421#comment-13165421 ]
Phabricator commented on HBASE-4969:
------------------------------------
stack has accepted the revision "HBASE-4969 [jira] tautology in HRegionInfo.readFields".
+1
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/HRegionInfo.java:740 Your fix looks right Prakash.
REVISION DETAIL
https://reviews.facebook.net/D669
> tautology in HRegionInfo.readFields
> -----------------------------------
>
> Key: HBASE-4969
> URL: https://issues.apache.org/jira/browse/HBASE-4969
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
> } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
> } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4969) tautology in HRegionInfo.readFields
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165468#comment-13165468 ]
Phabricator commented on HBASE-4969:
------------------------------------
nspiegelberg has commented on the revision "HBASE-4969 [jira] tautology in HRegionInfo.readFields".
@stack: have you run 'mvn initialize -Darc' on that directory yet?
REVISION DETAIL
https://reviews.facebook.net/D669
> tautology in HRegionInfo.readFields
> -----------------------------------
>
> Key: HBASE-4969
> URL: https://issues.apache.org/jira/browse/HBASE-4969
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Attachments: HBASE-4969.D669.1.patch
>
>
> In HRegionInfo.readFields() the following looks wrong to me
> } else if (getVersion() == VERSION) {
> it is always true.
> Should it have been
> } else if (getVersion() == version) {
> version is a local variable where the deserialized-version is stored.
> (I am struggling with another issue where after applying some patches - including "HBASE-4388 Second start after migration from 90 to trunk crashes" my version of hbase-92 HRegionInfo.readFields() tries to find HTD in HRegionInfo and fails)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira