[jira] [Commented] (ZOOKEEPER-2724) Skip cert files for releaseaudit target.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927013#comment-15927013 ] 

ASF GitHub Bot commented on ZOOKEEPER-2724:
-------------------------------------------

GitHub user hanm opened a pull request:

    https://github.com/apache/zookeeper/pull/194

    ZOOKEEPER-2724: Skip cert files for releaseaudit target.

    Skip the cert files as they are not source files, plus we already do the same for master branch..

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2724

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #194
    
----
commit bc51979fcde17d8472b1b16bbc9ed48483c9a559
Author: Michael Han <ha...@apache.org>
Date:   2017-03-15T21:25:38Z

    ZOOKEEPER-2724: Skip cert files for releaseaudit target.
    Skip the cert files as they are not source files.

----


> Skip cert files for releaseaudit target.
> ----------------------------------------
>
>                 Key: ZOOKEEPER-2724
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2724
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.5.2
>            Reporter: Michael Han
>            Assignee: Michael Han
>            Priority: Blocker
>              Labels: build
>             Fix For: 3.5.3
>
>
> In branch-3.5 release auditing generating warnings against cert files as these files don't contain Apache License (AL) header. I don't think these files should be checked because they are not source files, and we skip them in master branch. We should do the same for branch-3.5 by skipping these cert files as well. This should be fixed before 3.5.3 release.
> Attach the snippet of warning for reference:
> {noformat}
> [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/contrib/rest/conf/keys/rest.cer
> [rat:report]  !????? /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build/zookeeper-3.5.3-alpha-SNAPSHOT/src/contrib/rest/conf/keys/rest.cer
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)