[GitHub] [tvm] areusch commented on a change in pull request #9554: Implement [skip ci] for Jenkins

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #9554:
URL: https://github.com/apache/tvm/pull/9554#discussion_r768041428



##########
File path: tests/python/unittest/test_ci.py
##########
@@ -0,0 +1,116 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import pathlib
+import subprocess
+import sys
+import tempfile
+
+import pytest
+
+REPO_ROOT = pathlib.Path(__file__).resolve().parent.parent.parent.parent
+
+
+def test_skip_ci():
+    skip_ci_script = REPO_ROOT / "tests" / "scripts" / "git_skip_ci.py"
+
+    class TempGit:
+        def __init__(self, cwd):
+            self.cwd = cwd
+
+        def run(self, *args):
+            proc = subprocess.run(["git"] + list(args), cwd=self.cwd)
+            if proc.returncode != 0:
+                raise RuntimeError(f"git command failed: '{args}'")
+
+    def test(commands, should_skip, why):
+        with tempfile.TemporaryDirectory() as dir:
+            git = TempGit(dir)
+            # Jenkins git is too old and doesn't have 'git init --initial-branch'
+            git.run("init")
+            git.run("checkout", "-b", "main")
+            git.run("remote", "add", "origin", "https://github.com/apache/tvm.git")
+            git.run("config", "user.name", "ci")
+            git.run("config", "user.email", "email@example.com")
+            git.run("commit", "--allow-empty", "--message", "base commit")
+            for command in commands:
+                git.run(*command)
+            pr_number = "1234"
+            proc = subprocess.run(
+                [str(skip_ci_script), "--pr", pr_number, "--pr-title", "[skip ci] test"], cwd=dir
+            )
+            expected = 0 if should_skip else 1
+            assert proc.returncode == expected, why
+
+    test(
+        commands=[],
+        should_skip=False,
+        why="ci should not be skipped",
+    )
+
+    test(
+        commands=[
+            ["commit", "--allow-empty", "--message", "[skip ci] commit 1"],
+        ],
+        should_skip=False,
+        why="ci should not be skipped on main",
+    )
+
+    test(
+        commands=[
+            ["checkout", "-b", "some_new_branch"],
+            ["commit", "--allow-empty", "--message", "[skip ci] commit 1"],
+        ],
+        should_skip=True,
+        why="ci should be skipped on a branch with [skip ci] in the last commit",

Review comment:
       do we have a test for when `[skip ci]` is in a commit but not in PR title? i don't think we should allow only the commit to have `[skip ci]`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org