You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by xubo245 <gi...@git.apache.org> on 2019/01/07 01:55:37 UTC

[GitHub] carbondata pull request #3050: [CARBONDATA-3211] Optimize the documentation

Github user xubo245 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3050#discussion_r245534776
  
    --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapFactory.java ---
    @@ -57,7 +57,7 @@ public LuceneFineGrainDataMapFactory(CarbonTable carbonTable, DataMapSchema data
               DataMapWriter.getDefaultDataMapPath(tableIdentifier.getTablePath(),
                   segment.getSegmentNo(), dataMapName), segment.getConfiguration()));
         } catch (MemoryException e) {
    -      LOGGER.error("failed to get lucene datamap , detail is {}" + e.getMessage());
    +      LOGGER.error("failed to get lucene datamap, detail is {}" + e.getMessage());
    --- End diff --
    
    +1, it should can print the exception message, but String.format is better.


---