You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Ben Tatham (JIRA)" <ji...@codehaus.org> on 2010/05/17 18:07:12 UTC

[jira] Created: (MNG-4677) Plugin configuration incorrectly inherited from parent pom

Plugin configuration incorrectly inherited from parent pom
----------------------------------------------------------

                 Key: MNG-4677
                 URL: http://jira.codehaus.org/browse/MNG-4677
             Project: Maven 2 & 3
          Issue Type: Bug
    Affects Versions: 3.0-beta-1
            Reporter: Ben Tatham


Until 3.0-beta-1 this was working correctly, but now when I run release:perform, it runs the goals from the un-inherited plugin configuration instead of the one in pluginManagement that should be inherited.

In this example, the release plugin on the project should run goals: "deploy nmx-pom:dependency", but instead it is running "deploy nmx-pom:parent".  The latter is what the parent pom project itself runs on release.

It seems that maven is now ignoring the <inherited>false</inherited> flag, at least in some cases.

This is confirmed by the effective pom as well (see below).  Note that the effective pom in m2eclipse (that must still use the embedded maven instead of the external one I setup in Eclipse Preferences) has it correct.  

The release goals are all setup by the parent pom, which contains this:
...
  <build>
    <pluginManagement>
      <plugins>
        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-release-plugin</artifactId>
          <version>2.0-beta-9</version>
          <inherited>true</inherited>
          <configuration>
            <tagBase>http://svn/repos/libraries/java/${project.artifactId}/tags</tagBase>
            <useReleaseProfile>false</useReleaseProfile>
            <!-- goals to run during release:perform (removed site-deploy from default settings) -->
            <goals>deploy ca.nanometrics.maven:nmx-pom-plugin:dependency</goals>
            <arguments>-Dpom.update.skip=${pom.update.skip} -Dhudson.url=${hudson.url}
              -Dhudson.jobName=${hudson.jobName} -Dhudson.buildNumber=${hudson.buildNumber}</arguments>
          </configuration>
        </plugin>
    </pluginManagement>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-release-plugin</artifactId>
        <version>2.0-beta-9</version>
        <inherited>false</inherited>
        <configuration>
          <tagBase>http://svn/repos/tools/maven/common-pom/tags</tagBase>
          <useReleaseProfile>false</useReleaseProfile>
          <goals>deploy ca.nanometrics.maven:nmx-pom-plugin:${nmx-pom-plugin.version}:parent</goals>
          <arguments>-Dpom.update.skip=${pom.update.skip} -Dhudson.url=${hudson.url}
            -Dhudson.jobName=${hudson.jobName}
            -Dhudson.buildNumber=${hudson.buildNumber}</arguments>
        </configuration>
      </plugin>
</build>

The effective pom of the project itself, using 3.0-beta-1 has:
 ...
        <plugin>
          <artifactId>maven-release-plugin</artifactId>
          <version>2.0-beta-9</version>
          <inherited>true</inherited>
          <configuration>
            <tagBase>http://svn/repos/libraries/java/apollo-workstation/tags</tagBase>
            <useReleaseProfile>false</useReleaseProfile>
            <goals>deploy ca.nanometrics.maven:nmx-pom-plugin:dependency</goals>
            <arguments>-Dpom.update.skip=false -Dhudson.url=
              -Dhudson.jobName= -Dhudson.buildNumber=</arguments>
          </configuration>
        </plugin>
      </plugins>
    </pluginManagement>
    <plugins>
      <plugin>
        <artifactId>maven-release-plugin</artifactId>
        <version>2.0-beta-9</version>
        <inherited>false</inherited>
        <configuration>
          <tagBase>http://svn/repos/libraries/java/apollo/workstation/tags</tagBase>
          <useReleaseProfile>false</useReleaseProfile>
          <goals>deploy ca.nanometrics.maven:nmx-pom-plugin:1.3.3:parent</goals>
          <arguments>-Dpom.update.skip=false -Dhudson.url=
            -Dhudson.jobName=
            -Dhudson.buildNumber=</arguments>
        </configuration>
      </plugin>
...





-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MNG-4677) [regression] Plugin configuration incorrectly inherited from parent pom

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MNG-4677.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0-beta-2
         Assignee: Benjamin Bentmann

Fixed in [r945294|http://svn.apache.org/viewvc?view=revision&revision=945294].

> [regression] Plugin configuration incorrectly inherited from parent pom
> -----------------------------------------------------------------------
>
>                 Key: MNG-4677
>                 URL: http://jira.codehaus.org/browse/MNG-4677
>             Project: Maven 2 & 3
>          Issue Type: Bug
>    Affects Versions: 3.0-beta-1
>            Reporter: Ben Tatham
>            Assignee: Benjamin Bentmann
>             Fix For: 3.0-beta-2
>
>
> Until 3.0-beta-1 this was working correctly, but now when I run release:perform, it runs the goals from the un-inherited plugin configuration instead of the one in pluginManagement that should be inherited.
> In this example, the release plugin on the project should run goals: "deploy nmx-pom:dependency", but instead it is running "deploy nmx-pom:parent".  The latter is what the parent pom project itself runs on release.
> It seems that maven is now ignoring the <inherited>false</inherited> flag, at least in some cases.
> This is confirmed by the effective pom as well (see below).  Note that the effective pom in m2eclipse (that must still use the embedded maven instead of the external one I setup in Eclipse Preferences) has it correct.  
> The release goals are all setup by the parent pom, which contains this:
> ...
>   <build>
>     <pluginManagement>
>       <plugins>
>         <plugin>
>           <groupId>org.apache.maven.plugins</groupId>
>           <artifactId>maven-release-plugin</artifactId>
>           <version>2.0-beta-9</version>
>           <inherited>true</inherited>
>           <configuration>
>             <tagBase>http://svn/repos/libraries/java/${project.artifactId}/tags</tagBase>
>             <useReleaseProfile>false</useReleaseProfile>
>             <!-- goals to run during release:perform (removed site-deploy from default settings) -->
>             <goals>deploy ca.nanometrics.maven:nmx-pom-plugin:dependency</goals>
>             <arguments>-Dpom.update.skip=${pom.update.skip} -Dhudson.url=${hudson.url}
>               -Dhudson.jobName=${hudson.jobName} -Dhudson.buildNumber=${hudson.buildNumber}</arguments>
>           </configuration>
>         </plugin>
>     </pluginManagement>
>     <plugins>
>       <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-release-plugin</artifactId>
>         <version>2.0-beta-9</version>
>         <inherited>false</inherited>
>         <configuration>
>           <tagBase>http://svn/repos/tools/maven/common-pom/tags</tagBase>
>           <useReleaseProfile>false</useReleaseProfile>
>           <goals>deploy ca.nanometrics.maven:nmx-pom-plugin:${nmx-pom-plugin.version}:parent</goals>
>           <arguments>-Dpom.update.skip=${pom.update.skip} -Dhudson.url=${hudson.url}
>             -Dhudson.jobName=${hudson.jobName}
>             -Dhudson.buildNumber=${hudson.buildNumber}</arguments>
>         </configuration>
>       </plugin>
> </build>
> The effective pom of the project itself, using 3.0-beta-1 has:
>  ...
>         <plugin>
>           <artifactId>maven-release-plugin</artifactId>
>           <version>2.0-beta-9</version>
>           <inherited>true</inherited>
>           <configuration>
>             <tagBase>http://svn/repos/libraries/java/apollo-workstation/tags</tagBase>
>             <useReleaseProfile>false</useReleaseProfile>
>             <goals>deploy ca.nanometrics.maven:nmx-pom-plugin:dependency</goals>
>             <arguments>-Dpom.update.skip=false -Dhudson.url=
>               -Dhudson.jobName= -Dhudson.buildNumber=</arguments>
>           </configuration>
>         </plugin>
>       </plugins>
>     </pluginManagement>
>     <plugins>
>       <plugin>
>         <artifactId>maven-release-plugin</artifactId>
>         <version>2.0-beta-9</version>
>         <inherited>false</inherited>
>         <configuration>
>           <tagBase>http://svn/repos/libraries/java/apollo/workstation/tags</tagBase>
>           <useReleaseProfile>false</useReleaseProfile>
>           <goals>deploy ca.nanometrics.maven:nmx-pom-plugin:1.3.3:parent</goals>
>           <arguments>-Dpom.update.skip=false -Dhudson.url=
>             -Dhudson.jobName=
>             -Dhudson.buildNumber=</arguments>
>         </configuration>
>       </plugin>
> ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-4677) [regression] Plugin configuration incorrectly inherited from parent pom

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann updated MNG-4677:
-----------------------------------

    Summary: [regression] Plugin configuration incorrectly inherited from parent pom  (was: Plugin configuration incorrectly inherited from parent pom)

> [regression] Plugin configuration incorrectly inherited from parent pom
> -----------------------------------------------------------------------
>
>                 Key: MNG-4677
>                 URL: http://jira.codehaus.org/browse/MNG-4677
>             Project: Maven 2 & 3
>          Issue Type: Bug
>    Affects Versions: 3.0-beta-1
>            Reporter: Ben Tatham
>
> Until 3.0-beta-1 this was working correctly, but now when I run release:perform, it runs the goals from the un-inherited plugin configuration instead of the one in pluginManagement that should be inherited.
> In this example, the release plugin on the project should run goals: "deploy nmx-pom:dependency", but instead it is running "deploy nmx-pom:parent".  The latter is what the parent pom project itself runs on release.
> It seems that maven is now ignoring the <inherited>false</inherited> flag, at least in some cases.
> This is confirmed by the effective pom as well (see below).  Note that the effective pom in m2eclipse (that must still use the embedded maven instead of the external one I setup in Eclipse Preferences) has it correct.  
> The release goals are all setup by the parent pom, which contains this:
> ...
>   <build>
>     <pluginManagement>
>       <plugins>
>         <plugin>
>           <groupId>org.apache.maven.plugins</groupId>
>           <artifactId>maven-release-plugin</artifactId>
>           <version>2.0-beta-9</version>
>           <inherited>true</inherited>
>           <configuration>
>             <tagBase>http://svn/repos/libraries/java/${project.artifactId}/tags</tagBase>
>             <useReleaseProfile>false</useReleaseProfile>
>             <!-- goals to run during release:perform (removed site-deploy from default settings) -->
>             <goals>deploy ca.nanometrics.maven:nmx-pom-plugin:dependency</goals>
>             <arguments>-Dpom.update.skip=${pom.update.skip} -Dhudson.url=${hudson.url}
>               -Dhudson.jobName=${hudson.jobName} -Dhudson.buildNumber=${hudson.buildNumber}</arguments>
>           </configuration>
>         </plugin>
>     </pluginManagement>
>     <plugins>
>       <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-release-plugin</artifactId>
>         <version>2.0-beta-9</version>
>         <inherited>false</inherited>
>         <configuration>
>           <tagBase>http://svn/repos/tools/maven/common-pom/tags</tagBase>
>           <useReleaseProfile>false</useReleaseProfile>
>           <goals>deploy ca.nanometrics.maven:nmx-pom-plugin:${nmx-pom-plugin.version}:parent</goals>
>           <arguments>-Dpom.update.skip=${pom.update.skip} -Dhudson.url=${hudson.url}
>             -Dhudson.jobName=${hudson.jobName}
>             -Dhudson.buildNumber=${hudson.buildNumber}</arguments>
>         </configuration>
>       </plugin>
> </build>
> The effective pom of the project itself, using 3.0-beta-1 has:
>  ...
>         <plugin>
>           <artifactId>maven-release-plugin</artifactId>
>           <version>2.0-beta-9</version>
>           <inherited>true</inherited>
>           <configuration>
>             <tagBase>http://svn/repos/libraries/java/apollo-workstation/tags</tagBase>
>             <useReleaseProfile>false</useReleaseProfile>
>             <goals>deploy ca.nanometrics.maven:nmx-pom-plugin:dependency</goals>
>             <arguments>-Dpom.update.skip=false -Dhudson.url=
>               -Dhudson.jobName= -Dhudson.buildNumber=</arguments>
>           </configuration>
>         </plugin>
>       </plugins>
>     </pluginManagement>
>     <plugins>
>       <plugin>
>         <artifactId>maven-release-plugin</artifactId>
>         <version>2.0-beta-9</version>
>         <inherited>false</inherited>
>         <configuration>
>           <tagBase>http://svn/repos/libraries/java/apollo/workstation/tags</tagBase>
>           <useReleaseProfile>false</useReleaseProfile>
>           <goals>deploy ca.nanometrics.maven:nmx-pom-plugin:1.3.3:parent</goals>
>           <arguments>-Dpom.update.skip=false -Dhudson.url=
>             -Dhudson.jobName=
>             -Dhudson.buildNumber=</arguments>
>         </configuration>
>       </plugin>
> ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira