You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2014/08/20 19:22:12 UTC

Review Request 24896: SAMZA-381

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24896/
-----------------------------------------------------------

Review request for samza.


Bugs: SAMZA-381
    https://issues.apache.org/jira/browse/SAMZA-381


Repository: samza


Description
-------

update log4j docs


clarify readme a bit more


update readme to use baseurl and remove version number


Diffs
-----

  docs/README.md e31b2ebae39d0b0160a8030ed630173746fad8bf 
  docs/learn/documentation/versioned/jobs/logging.md 6af3d4d1c3203edb3043ee2dc0ef2f359f50f701 

Diff: https://reviews.apache.org/r/24896/diff/


Testing
-------


Thanks,

Chris Riccomini

Re: Review Request 24896: SAMZA-381

Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24896/#review51115
-----------------------------------------------------------



docs/learn/documentation/versioned/jobs/logging.md
<https://reviews.apache.org/r/24896/#comment89139>

    Not the /tmp, actually it looks for the $base_dir, if the SAMZA_LOG_DIR is not defined. (I pointed it out in SAMZA-292). Since you are modifing this page anyway, could you correct this one as well? :)


- Yan Fang


On Aug. 20, 2014, 5:22 p.m., Chris Riccomini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24896/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 5:22 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-381
>     https://issues.apache.org/jira/browse/SAMZA-381
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> update log4j docs
> 
> 
> clarify readme a bit more
> 
> 
> update readme to use baseurl and remove version number
> 
> 
> Diffs
> -----
> 
>   docs/README.md e31b2ebae39d0b0160a8030ed630173746fad8bf 
>   docs/learn/documentation/versioned/jobs/logging.md 6af3d4d1c3203edb3043ee2dc0ef2f359f50f701 
> 
> Diff: https://reviews.apache.org/r/24896/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Riccomini
> 
>