You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/03/21 10:54:21 UTC

[GitHub] [spark] itholic commented on a diff in pull request #40507: [SPARK-42662][CONNECT][PS] Add `_distributed_sequence_id` for distributed-sequence index.

itholic commented on code in PR #40507:
URL: https://github.com/apache/spark/pull/40507#discussion_r1143198700


##########
python/pyspark/sql/connect/functions.py:
##########
@@ -2471,6 +2472,13 @@ def udf(
 udf.__doc__ = pysparkfuncs.udf.__doc__
 
 
+def _distributed_sequence_id() -> Column:

Review Comment:
   Oh, it supposed to be used to create the default index of the pandas API on Spark in the follow-up PR.
   
   Since the subsequent PR will include a many code fixes and tests, so I separate the current work for review convenience.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org