You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2017/11/09 18:57:59 UTC

[GitHub] brooklyn-server pull request #890: REST `/applications/fetch` can request se...

GitHub user ahgittin opened a pull request:

    https://github.com/apache/brooklyn-server/pull/890

    REST `/applications/fetch` can request selected sensors

    This allows clients to efficiently get selected sensors they are interested in.
    
    Does this by adding a `@JsonAnyGetter` map to `EntitySummary`, as done for `TypeSummary` and elsewhere, returning data in `sensors` key.
    
    Re-enables the `fetch` test (disabled in #156) to assert this, but with better logging if the problem recurs.
    
    Also sets batch config read task as transient so it doesn't clutter the activities view.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/brooklyn-server rest-api-application-sensors

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/890.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #890
    
----
commit a70a5535b09d474153a2e71e8db5c6528a58107c
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2017-11-02T16:50:53Z

    allow Task.warning that doesn't log

commit 2900156d8988a16e2c7de8847de648ceaa62cfae
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2017-11-02T16:51:06Z

    support more ManagementContext.lookup including predicates, adjuncts, lookupAll

commit 447cac711463f5ef1bf685759f167e88580b759e
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2017-11-03T14:13:50Z

    suppress warning on task finalization if its execution context is shutdown

commit 6fa3b7aa1bd21eb12fcc00b03d172f1773362263
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2017-11-03T14:14:15Z

    routine to `assertEntityHealthyEventually`

commit 4f607ecee1cdb00e112244375be3fdd60fb79400
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2017-11-09T18:52:58Z

    Merge branch 'enhancements' into r2

commit ff1ed3cd66be2168f8386da163fb287b131bf54e
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2017-11-09T18:51:17Z

    mark the batch config read as transient
    
    otherwise it wipes out other things from activity history

commit ba1c37c54e980647e2a6029e84e279986c1eab04
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date:   2017-11-09T18:45:42Z

    add to REST API ability to include specific sensors when fetching

----


---

[GitHub] brooklyn-server pull request #890: REST `/applications/fetch` can request se...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/890


---

[GitHub] brooklyn-server issue #890: REST `/applications/fetch` can request selected ...

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/890
  
    Last two commits here LGTM.


---

[GitHub] brooklyn-server issue #890: REST `/applications/fetch` can request selected ...

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/890
  
    Note it's just the last two commits here; the others come from #878 (we now use the `lookup(Predicate)` convenience in the test)


---

[GitHub] brooklyn-server issue #890: REST `/applications/fetch` can request selected ...

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/890
  
    K - good to merge after #879


---