[jira] [Resolved] (OAK-3361) Reduce PerfLogger isDebugEnabled overhead

["Marcel Reutegger (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-3361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marcel Reutegger resolved OAK-3361.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.3.6

Looks good to me.

Applied patch to trunk: http://svn.apache.org/r1701613

Thanks for the patch!

> Reduce PerfLogger isDebugEnabled overhead
> -----------------------------------------
>
>                 Key: OAK-3361
>                 URL: https://issues.apache.org/jira/browse/OAK-3361
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.3.4
>            Reporter: Joel Richard
>            Assignee: Marcel Reutegger
>            Priority: Minor
>              Labels: performance
>             Fix For: 1.3.6
>
>         Attachments: 0001-OAK-3361-Reduce-PerfLogger-isDebugEnabled-overhead.patch
>
>
> If a node is cached, 1/4 of the time which is used to call DocumentNodeStore.getNode is spent in PerfLogger.start and PerfLogger.end just for checking whether or not debug logging is enabled (this is likely much less if no TurboFilters are used).
> To reduce the overhead of the PerfLogger, it should not check if debug is enabled in end() if start is below 0 anyway. Moreover, it would help to check only every second if debug is really enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)