You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/07/13 06:34:34 UTC

[Bug 55259] New: Unnecessary work in JspConfig

https://issues.apache.org/bugzilla/show_bug.cgi?id=55259

            Bug ID: 55259
           Summary: Unnecessary work in JspConfig
           Product: Tomcat 8
           Version: trunk
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Jasper
          Assignee: dev@tomcat.apache.org
          Reporter: jboynes@apache.org

JspProperty is the same for all url patterns in a group; the current code
creates a new one each iteration

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 55259] Unnecessary work in JspConfig

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55259

--- Comment #3 from Jeremy Boynes <jb...@apache.org> ---
Fixed in trunk: http://svn.apache.org/r1502897

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Committing, was: [Bug 55259] Unnecessary work in JspConfig

Posted by Jeremy Boynes <jb...@apache.org>.
On Jul 13, 2013, at 2:43 AM, bugzilla@apache.org wrote:

> https://issues.apache.org/bugzilla/show_bug.cgi?id=55259
> 
> --- Comment #2 from Mark Thomas <ma...@apache.org> ---
> Jeremy,
> 
> Although you were originally granted commit karma due to your taglibs work, you
> have the necessary karma to commit to any part of the Tomcat tree. You clearly
> know what you are doing so feel free to use it :)

Thank you. I appreciate you taking the time to review my patches and for providing
your feedback on them.

> 
> A couple of things to note although I suspect you know all this already anyway:
> - commits should normally be made to trunk and then backported (trunk -> 7.0.x
> -> 6.0.x) as appropriate
> - trunk and 7.0.x are CTR but 6.0.x is RTC so proposals need to be added to the
> status file for 6.0.x
> - the trunk changelog entries are currently limited to those changes that won't
> be back-ported
> - the changelogs have a comment at the top that explain the order of entries

My current itch is around the JSP support and the changes there will depend
on the descriptor changes which we don't intend to backport.  There may be
specific changes, like this one perhaps, that could also apply to 7.0.x but I
would appreciate a second set of eyes on them before I make any changes in 
that branch.

> 
> Have fun!

Again, thanks :)
Jeremy


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 55259] Unnecessary work in JspConfig

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55259

--- Comment #2 from Mark Thomas <ma...@apache.org> ---
Jeremy,

Although you were originally granted commit karma due to your taglibs work, you
have the necessary karma to commit to any part of the Tomcat tree. You clearly
know what you are doing so feel free to use it :)

A couple of things to note although I suspect you know all this already anyway:
- commits should normally be made to trunk and then backported (trunk -> 7.0.x
-> 6.0.x) as appropriate
- trunk and 7.0.x are CTR but 6.0.x is RTC so proposals need to be added to the
status file for 6.0.x
- the trunk changelog entries are currently limited to those changes that won't
be back-ported
- the changelogs have a comment at the top that explain the order of entries

Have fun!

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: [Bug 55259] Unnecessary work in JspConfig

Posted by Jeremy Boynes <jb...@apache.org>.
On Jul 16, 2013, at 10:27 AM, Christopher Schultz <ch...@christopherschultz.net> wrote:

> Jeremy,
> 
> On 7/13/13 6:11 PM, bugzilla@apache.org wrote:
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=55259
>> 
>> Jeremy Boynes <jb...@apache.org> changed:
>> 
>>           What    |Removed                     |Added
>> ----------------------------------------------------------------------------
>>             Status|NEW                         |RESOLVED
>>         Resolution|---                         |FIXED
>> 
> 
> It's typical to mention in what version(s) the fix has been made when
> marking a bug as FIXED. I usually try to add the svn revision number,
> too, in case anyone is interested.

Thanks. Done.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: [Bug 55259] Unnecessary work in JspConfig

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Jeremy,

On 7/13/13 6:11 PM, bugzilla@apache.org wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=55259
> 
> Jeremy Boynes <jb...@apache.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|NEW                         |RESOLVED
>          Resolution|---                         |FIXED
> 

It's typical to mention in what version(s) the fix has been made when
marking a bug as FIXED. I usually try to add the svn revision number,
too, in case anyone is interested.

-chris

[Bug 55259] Unnecessary work in JspConfig

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55259

Jeremy Boynes <jb...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 55259] Unnecessary work in JspConfig

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55259

--- Comment #1 from Jeremy Boynes <jb...@apache.org> ---
Created attachment 30588
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30588&action=edit
patch to move instantiation outside the loop

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org