You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/17 22:39:13 UTC

[GitHub] [incubator-mxnet] access2rohit commented on a change in pull request #18925: Numpy Dot Large Tensor Fix

access2rohit commented on a change in pull request #18925:
URL: https://github.com/apache/incubator-mxnet/pull/18925#discussion_r471812842



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -76,3 +77,11 @@ def test_softmax():
         true_output = np.full((SMALL_Y, LARGE_X), (1 / input_data.shape[axis]))
         output = npx.softmax(input_data, axis=axis)
         assert_almost_equal(output.asnumpy(), true_output, rtol=1e-5, atol=1e-5)
+
+@pytest.mark.skip(reason="CI hasn't switch to ILP64 OpenBLAS yet")

Review comment:
       tests for same operator in same file will increase file size. I like the decorator idea but any specific reason to keep both tests in same file ?
   
   @Zha0q1 I will review it in a while




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org