You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:49:00 UTC

[GitHub] [flink] JingsongLi opened a new pull request #12334: [FLINK-17934][fs-connector] StreamingFileWriter should set chainingStrategy

JingsongLi opened a new pull request #12334:
URL: https://github.com/apache/flink/pull/12334


   
   ## What is the purpose of the change & Brief change log
   
   - StreamingFileWriter should set chainingStrategy
   - Get BucketLifeCycleListener from buckets instead of depending on Java serialization reference mechanism.
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12334: [FLINK-17934][FLINK-17955][fs-connector] StreamingFileWriter should set chainingStrategy & BucketLifeCycleListener should just in Buckets

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12334:
URL: https://github.com/apache/flink/pull/12334#issuecomment-633879796


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "054aceb94feb7fd66916f4502de647b9b0f0a949",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2190",
       "triggerID" : "054aceb94feb7fd66916f4502de647b9b0f0a949",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e3f49ff243a1ef02b1fe3caeb4001e42d2c38636",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2242",
       "triggerID" : "e3f49ff243a1ef02b1fe3caeb4001e42d2c38636",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96752af4aabbb367eb4150477dc1b835dbf303dd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "96752af4aabbb367eb4150477dc1b835dbf303dd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e3f49ff243a1ef02b1fe3caeb4001e42d2c38636 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2242) 
   * 96752af4aabbb367eb4150477dc1b835dbf303dd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12334: [FLINK-17934][FLINK-17955][fs-connector] StreamingFileWriter should set chainingStrategy & BucketLifeCycleListener should just in Buckets

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12334:
URL: https://github.com/apache/flink/pull/12334#issuecomment-633879796


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "054aceb94feb7fd66916f4502de647b9b0f0a949",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2190",
       "triggerID" : "054aceb94feb7fd66916f4502de647b9b0f0a949",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e3f49ff243a1ef02b1fe3caeb4001e42d2c38636",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2242",
       "triggerID" : "e3f49ff243a1ef02b1fe3caeb4001e42d2c38636",
       "triggerType" : "PUSH"
     }, {
       "hash" : "96752af4aabbb367eb4150477dc1b835dbf303dd",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2244",
       "triggerID" : "96752af4aabbb367eb4150477dc1b835dbf303dd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e3f49ff243a1ef02b1fe3caeb4001e42d2c38636 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2242) 
   * 96752af4aabbb367eb4150477dc1b835dbf303dd Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2244) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi merged pull request #12334: [FLINK-17934][FLINK-17955][fs-connector] StreamingFileWriter should set chainingStrategy & BucketLifeCycleListener should just in Buckets

Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12334:
URL: https://github.com/apache/flink/pull/12334


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi commented on pull request #12334: [FLINK-17934][FLINK-17955][fs-connector] StreamingFileWriter should set chainingStrategy & BucketLifeCycleListener should just in Buckets

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12334:
URL: https://github.com/apache/flink/pull/12334#issuecomment-634510340


   Thanks @sjwiesman @gaoyunhaii for review, merging...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12334: [FLINK-17934][FLINK-17955][fs-connector] StreamingFileWriter should set chainingStrategy & BucketLifeCycleListener should just in Buckets

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12334:
URL: https://github.com/apache/flink/pull/12334#issuecomment-633879796


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "054aceb94feb7fd66916f4502de647b9b0f0a949",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2190",
       "triggerID" : "054aceb94feb7fd66916f4502de647b9b0f0a949",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e3f49ff243a1ef02b1fe3caeb4001e42d2c38636",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e3f49ff243a1ef02b1fe3caeb4001e42d2c38636",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 054aceb94feb7fd66916f4502de647b9b0f0a949 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2190) 
   * e3f49ff243a1ef02b1fe3caeb4001e42d2c38636 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi commented on pull request #12334: [FLINK-17934][FLINK-17955][fs-connector] StreamingFileWriter should set chainingStrategy & BucketLifeCycleListener should just in Buckets

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12334:
URL: https://github.com/apache/flink/pull/12334#issuecomment-634510197


   Test case should be: https://issues.apache.org/jira/browse/FLINK-17260


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] JingsongLi commented on pull request #12334: [FLINK-17934][fs-connector] StreamingFileWriter should set chainingStrategy

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on pull request #12334:
URL: https://github.com/apache/flink/pull/12334#issuecomment-633861974


   CC: @gaoyunhaii 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12334: [FLINK-17934][fs-connector] StreamingFileWriter should set chainingStrategy

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12334:
URL: https://github.com/apache/flink/pull/12334#issuecomment-633862351






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12334: [FLINK-17934][FLINK-17955][fs-connector] StreamingFileWriter should set chainingStrategy & BucketLifeCycleListener should just in Buckets

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12334:
URL: https://github.com/apache/flink/pull/12334#issuecomment-633879796


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "054aceb94feb7fd66916f4502de647b9b0f0a949",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2190",
       "triggerID" : "054aceb94feb7fd66916f4502de647b9b0f0a949",
       "triggerType" : "PUSH"
     }, {
       "hash" : "e3f49ff243a1ef02b1fe3caeb4001e42d2c38636",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2242",
       "triggerID" : "e3f49ff243a1ef02b1fe3caeb4001e42d2c38636",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e3f49ff243a1ef02b1fe3caeb4001e42d2c38636 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2242) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12334: [FLINK-17934][FLINK-17955][fs-connector] StreamingFileWriter should set chainingStrategy & BucketLifeCycleListener should just in Buckets

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12334:
URL: https://github.com/apache/flink/pull/12334#issuecomment-633862351


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 96752af4aabbb367eb4150477dc1b835dbf303dd (Fri Oct 16 10:56:43 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12334: [FLINK-17934][fs-connector] StreamingFileWriter should set chainingStrategy

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12334:
URL: https://github.com/apache/flink/pull/12334#issuecomment-633879796






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org