[GitHub] ZiyueHuang commented on a change in pull request #8814: csr slice operator, gpu implementation

[GitBox <gi...@apache.org>]

ZiyueHuang commented on a change in pull request #8814: csr slice operator, gpu implementation
URL: https://github.com/apache/incubator-mxnet/pull/8814#discussion_r153259808
 
 

 ##########
 File path: src/operator/tensor/matrix_op-inl.h
 ##########
 @@ -471,10 +467,15 @@ void SliceDimOneCsrImpl(const TShape &begin, const TShape &end, const OpContext&
       MSHADOW_TYPE_SWITCH(in.dtype(), DType, {
         RType* in_indptr = in.aux_data(kIndPtr).dptr<RType>();
         RType* out_indptr = out.aux_data(kIndPtr).dptr<RType>();
-        SliceCsrIndPtrImpl<cpu, RType>(begin_row, end_row, ctx.run_ctx, in_indptr, out_indptr);
+        SliceCsrIndPtrImpl<xpu, RType>(begin_row, end_row, ctx.run_ctx, in_indptr, out_indptr);
 
-        // retrieve nnz (CPU implementation)
-        int nnz = out_indptr[indptr_len - 1];
+        Stream<xpu> *s = ctx.get_stream<xpu>();
+        // wait SliceCsrIndPtrImpl to complete
+        s->Wait();
 
 Review comment:
   Since `nnz` is used immediately after `mshadow::Copy`. So `s->Wait()` is used here, to wait for the computation on `out_indptr` to complete.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services