You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mikhail Fursov (JIRA)" <ji...@apache.org> on 2007/03/19 15:05:32 UTC
[jira] Created: (HARMONY-3426) [drlvm][win64] Problem with callee
save registers on Win64T
[drlvm][win64] Problem with callee save registers on Win64T
-----------------------------------------------------------
Key: HARMONY-3426
URL: https://issues.apache.org/jira/browse/HARMONY-3426
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Mikhail Fursov
Attachments: cc.diff
On windows64 platform RDI and RSI are callee-save registers.
DRLVM does not treat these registers as callee-save and it can lead to a problem with native methods calls.
This patch fixes JIT and VM handling RSI and RDI on windows.
Please review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3426) [drlvm][winx64] Problem with callee
save registers on Win64T
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov reassigned HARMONY-3426:
----------------------------------------
Assignee: Alexey Varlamov
> [drlvm][winx64] Problem with callee save registers on Win64T
> ------------------------------------------------------------
>
> Key: HARMONY-3426
> URL: https://issues.apache.org/jira/browse/HARMONY-3426
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: Alexey Varlamov
> Attachments: cc.diff
>
>
> On windows64 platform RDI and RSI are callee-save registers.
> DRLVM does not treat these registers as callee-save and it can lead to a problem with native methods calls.
> This patch fixes JIT and VM handling RSI and RDI on windows.
> Please review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3426) [drlvm][winx64] Problem with
callee save registers on Win64T
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482305 ]
Alexey Varlamov commented on HARMONY-3426:
------------------------------------------
Looks good except the following:
--- vm/jitrino/src/jet/compiler.cpp (revision 519916)
+++ vm/jitrino/src/jet/compiler.cpp (working copy)
@@ -1448,7 +1448,7 @@
- rt_suspend_req_flag_offset = hythread_tls_get_suspend_request_offset();
+ rt_suspend_req_flag_offset = (unsigned)hythread_tls_get_suspend_request_offset();
Apparently hythread_tls_get_suspend_request_offset() should return size_t instead of UDATA, let's fix this accordingly instead of adding casts.
> [drlvm][winx64] Problem with callee save registers on Win64T
> ------------------------------------------------------------
>
> Key: HARMONY-3426
> URL: https://issues.apache.org/jira/browse/HARMONY-3426
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Mikhail Fursov
> Attachments: cc.diff
>
>
> On windows64 platform RDI and RSI are callee-save registers.
> DRLVM does not treat these registers as callee-save and it can lead to a problem with native methods calls.
> This patch fixes JIT and VM handling RSI and RDI on windows.
> Please review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3426) [drlvm][winx64] Problem with
callee save registers on Win64T
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482228 ]
Ilya Berezhniuk commented on HARMONY-3426:
------------------------------------------
The patch is very important and looks great (although I can't say anything about changes in EdgeProfiler.cpp).
I suggest commiting it ASAP.
> [drlvm][winx64] Problem with callee save registers on Win64T
> ------------------------------------------------------------
>
> Key: HARMONY-3426
> URL: https://issues.apache.org/jira/browse/HARMONY-3426
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Mikhail Fursov
> Attachments: cc.diff
>
>
> On windows64 platform RDI and RSI are callee-save registers.
> DRLVM does not treat these registers as callee-save and it can lead to a problem with native methods calls.
> This patch fixes JIT and VM handling RSI and RDI on windows.
> Please review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3426) [drlvm][winx64] Problem with callee
save registers on Win64T
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky updated HARMONY-3426:
---------------------------------------
Summary: [drlvm][winx64] Problem with callee save registers on Win64T (was: [drlvm][win64] Problem with callee save registers on Win64T)
> [drlvm][winx64] Problem with callee save registers on Win64T
> ------------------------------------------------------------
>
> Key: HARMONY-3426
> URL: https://issues.apache.org/jira/browse/HARMONY-3426
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Mikhail Fursov
> Attachments: cc.diff
>
>
> On windows64 platform RDI and RSI are callee-save registers.
> DRLVM does not treat these registers as callee-save and it can lead to a problem with native methods calls.
> This patch fixes JIT and VM handling RSI and RDI on windows.
> Please review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3426) [drlvm][win64] Problem with callee
save registers on Win64T
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Fursov updated HARMONY-3426:
------------------------------------
Attachment: cc.diff
> [drlvm][win64] Problem with callee save registers on Win64T
> -----------------------------------------------------------
>
> Key: HARMONY-3426
> URL: https://issues.apache.org/jira/browse/HARMONY-3426
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Mikhail Fursov
> Attachments: cc.diff
>
>
> On windows64 platform RDI and RSI are callee-save registers.
> DRLVM does not treat these registers as callee-save and it can lead to a problem with native methods calls.
> This patch fixes JIT and VM handling RSI and RDI on windows.
> Please review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3426) [drlvm][winx64] Problem with callee
save registers on Win64T
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Varlamov resolved HARMONY-3426.
--------------------------------------
Resolution: Fixed
Applied at r521134 except EdgeProfiler.cpp mods.
Let the cast go in to minimize intrusion...
> [drlvm][winx64] Problem with callee save registers on Win64T
> ------------------------------------------------------------
>
> Key: HARMONY-3426
> URL: https://issues.apache.org/jira/browse/HARMONY-3426
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Mikhail Fursov
> Assigned To: Alexey Varlamov
> Attachments: cc.diff
>
>
> On windows64 platform RDI and RSI are callee-save registers.
> DRLVM does not treat these registers as callee-save and it can lead to a problem with native methods calls.
> This patch fixes JIT and VM handling RSI and RDI on windows.
> Please review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3426) [drlvm][winx64] Problem with
callee save registers on Win64T
Posted by "Mikhail Fursov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482334 ]
Mikhail Fursov commented on HARMONY-3426:
-----------------------------------------
I added the cast above because I've seen a warning during compilation from MSVS2005
Could I ask commiter to fix the cast to avoid sending new diffs?
> [drlvm][winx64] Problem with callee save registers on Win64T
> ------------------------------------------------------------
>
> Key: HARMONY-3426
> URL: https://issues.apache.org/jira/browse/HARMONY-3426
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Mikhail Fursov
> Attachments: cc.diff
>
>
> On windows64 platform RDI and RSI are callee-save registers.
> DRLVM does not treat these registers as callee-save and it can lead to a problem with native methods calls.
> This patch fixes JIT and VM handling RSI and RDI on windows.
> Please review.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.