You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2017/06/24 01:05:15 UTC
[GitHub] cordova-ios pull request #322: CB-12948 - Add a warning to updateProject for...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/322
CB-12948 - Add a warning to updateProject for iOS
### Platforms affected
self
### What does this PR do?
Remove the `cordova platform update` functionality of this platform, and provide text on what to do instead (remove, then add the platform). We treat the platforms folder as a build artifact.
### What testing has been done on this change?
Created a project, added an older platform, and updated to the platform in this PR. It prints out the error text expected.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-12948
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #322
----
commit 2b8d9d251571f043b58d5649b7a0d21b345c9222
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2017-06-24T00:57:48Z
CB-12948 - Add a warning to updateProject for iOS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #322: CB-12948 - Add a warning to updateProject for iOS
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/322
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=h1) Report
> Merging [#322](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4490abf273ec6d12810c8ff5ea16d197c58ecd4b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 63.77% 63.77%
=======================================
Files 14 14
Lines 1623 1623
Branches 277 277
=======================================
Hits 1035 1035
Misses 588 588
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=footer). Last update [4490abf...4fbaebd](https://codecov.io/gh/apache/cordova-ios/pull/322?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #322: CB-12948 - Add a warning to updateProject for...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org