You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by pa...@apache.org on 2017/03/06 18:28:12 UTC

[1/5] [lang] add changes.xml entry for LANG-1314

Repository: commons-lang
Updated Branches:
  refs/heads/master e5ed4ffe5 -> d43e1d019


add changes.xml entry for LANG-1314


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/d43e1d01
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/d43e1d01
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/d43e1d01

Branch: refs/heads/master
Commit: d43e1d01981d321b85a8ccae788da4d818548dbe
Parents: 0ba25aa
Author: pascalschumacher <pa...@gmx.net>
Authored: Mon Mar 6 19:27:02 2017 +0100
Committer: pascalschumacher <pa...@gmx.net>
Committed: Mon Mar 6 19:27:36 2017 +0100

----------------------------------------------------------------------
 src/changes/changes.xml | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/d43e1d01/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 4419d95..5b2cb64 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -78,6 +78,7 @@ The <action> type attribute can be add,update,fix,remove.
     <action issue="LANG-1311" type="fix" dev="pschumacher" due-to="Aaron Digulla">TypeUtils.toString() doesn't handle primitive and Object arrays correctly</action>
     <action issue="LANG-1312" type="fix" dev="pschumacher">LocaleUtils#toLocale does not support language followed by UN M.49 numeric-3 area code</action>
     <action issue="LANG-1265" type="fix" dev="pschumacher">Build failures when building with Java 9 EA</action>
+    <action issue="LANG-1314" type="fix" dev="pschumacher" due-to="Allon Murienik">Fix javadoc creation on with Java 8</action>
   </release>
 
   <release version="3.5" date="2016-10-13" description="New features including Java 9 detection">


[4/5] [lang] Add javadoc creation to Travis CI (closes #252)

Posted by pa...@apache.org.
Add javadoc creation to Travis CI (closes #252)


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/0ba25aa9
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/0ba25aa9
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/0ba25aa9

Branch: refs/heads/master
Commit: 0ba25aa97bf80e001645bcb1fb597c7f704b0f29
Parents: 7337507
Author: Allon Mureinik <am...@redhat.com>
Authored: Sun Mar 5 18:03:01 2017 +0200
Committer: pascalschumacher <pa...@gmx.net>
Committed: Mon Mar 6 19:27:36 2017 +0100

----------------------------------------------------------------------
 .travis.yml | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/0ba25aa9/.travis.yml
----------------------------------------------------------------------
diff --git a/.travis.yml b/.travis.yml
index a969aba..4e3fd53 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -21,5 +21,8 @@ jdk:
   - oraclejdk7
   - oraclejdk8
 
+script:
+  - mvn test javadoc:javadoc -B
+
 after_success:
   - mvn clean apache-rat:check cobertura:cobertura coveralls:report


[3/5] [lang] LANG-1314: Fix javadoc creation on with Java 8

Posted by pa...@apache.org.
LANG-1314: Fix javadoc creation on with Java 8

Add @param for <T> in ArrayUtils#insert


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/a0f9db28
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/a0f9db28
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/a0f9db28

Branch: refs/heads/master
Commit: a0f9db28319f45feb56982d21239fed451b6c3ef
Parents: e5ed4ff
Author: pascalschumacher <pa...@gmx.net>
Authored: Mon Mar 6 19:22:14 2017 +0100
Committer: pascalschumacher <pa...@gmx.net>
Committed: Mon Mar 6 19:27:36 2017 +0100

----------------------------------------------------------------------
 src/main/java/org/apache/commons/lang3/ArrayUtils.java | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/a0f9db28/src/main/java/org/apache/commons/lang3/ArrayUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/ArrayUtils.java b/src/main/java/org/apache/commons/lang3/ArrayUtils.java
index b09e891..4ced70c 100644
--- a/src/main/java/org/apache/commons/lang3/ArrayUtils.java
+++ b/src/main/java/org/apache/commons/lang3/ArrayUtils.java
@@ -8408,12 +8408,13 @@ public class ArrayUtils {
      * ArrayUtils.insert(index, array, null)     = cloned copy of 'array'
      * ArrayUtils.insert(index, null, values)    = null
      * </pre>
-     *  
+     *
+     * @param <T> The type of elements in {@code array} and {@code values}
      * @param index the position within {@code array} to insert the new values
      * @param array the array to insert the values into, may be {@code null}
      * @param values the new values to insert, may be {@code null}
      * @return The new array.
-     * @throws IndexOutOfBoundsException if {@code array} is provided 
+     * @throws IndexOutOfBoundsException if {@code array} is provided
      * and either {@code index < 0} or {@code index > array.length}
      * @since 3.6
      */


[5/5] [lang] LANG-1314: Fix javadoc creation on with Java 8

Posted by pa...@apache.org.
LANG-1314: Fix javadoc creation on with Java 8

Fix StirngUtils </p> tags in javadoc

The paragraph

</p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>

appears in several places in the javadoc (presumably, copy-pasted from
the original one to the others). This is obviously a mistake, as a
paragraph should start with <p>, not with </p>.

This patch fixes all the occurrences of this paragraph to the proper
form:

<p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/0f5c769e
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/0f5c769e
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/0f5c769e

Branch: refs/heads/master
Commit: 0f5c769e0c27a5f31a3451aa7372048bed08e9f7
Parents: a0f9db2
Author: pascalschumacher <pa...@gmx.net>
Authored: Mon Mar 6 19:22:49 2017 +0100
Committer: pascalschumacher <pa...@gmx.net>
Committed: Mon Mar 6 19:27:36 2017 +0100

----------------------------------------------------------------------
 .../java/org/apache/commons/lang3/StringUtils.java  | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/0f5c769e/src/main/java/org/apache/commons/lang3/StringUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java
index 8049850..a92c4df 100644
--- a/src/main/java/org/apache/commons/lang3/StringUtils.java
+++ b/src/main/java/org/apache/commons/lang3/StringUtils.java
@@ -313,7 +313,7 @@ public class StringUtils {
     /**
      * <p>Checks if a CharSequence is empty (""), null or whitespace only.</p>
      * 
-     * </p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
+     * <p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
      *
      * <pre>
      * StringUtils.isBlank(null)      = true
@@ -344,7 +344,7 @@ public class StringUtils {
     /**
      * <p>Checks if a CharSequence is not empty (""), not null and not whitespace only.</p>
      * 
-     * </p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
+     * <p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
      *
      * <pre>
      * StringUtils.isNotBlank(null)      = false
@@ -367,7 +367,7 @@ public class StringUtils {
     /**
      * <p>Checks if any of the CharSequences are empty ("") or null or whitespace only.</p>
      * 
-     * </p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
+     * <p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
      *
      * <pre>
      * StringUtils.isAnyBlank(null)             = true
@@ -400,7 +400,7 @@ public class StringUtils {
     /**
      * <p>Checks if any of the CharSequences are not empty (""), not null and not whitespace only.</p>
      * 
-     * </p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
+     * <p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
      *
      * <pre>
      * StringUtils.isAnyNotBlank(null)             = false
@@ -433,7 +433,7 @@ public class StringUtils {
     /**
      * <p>Checks if none of the CharSequences are empty (""), null or whitespace only.</p>
      * 
-     * </p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
+     * <p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
      *
      * <pre>
      * StringUtils.isNoneBlank(null)             = false
@@ -1943,7 +1943,7 @@ public class StringUtils {
     /**
      * <p>Check whether the given CharSequence contains any whitespace characters.</p>
      * 
-     * </p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
+     * <p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
      * 
      * @param seq the CharSequence to check (may be {@code null})
      * @return {@code true} if the CharSequence is not empty and
@@ -7089,7 +7089,7 @@ public class StringUtils {
     /**
      * <p>Checks if the CharSequence contains only whitespace.</p>
      * 
-     * </p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
+     * <p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
      *
      * <p>{@code null} will return {@code false}.
      * An empty CharSequence (length()=0) will return {@code true}.</p>
@@ -7238,7 +7238,7 @@ public class StringUtils {
      * <p>Returns either the passed in CharSequence, or if the CharSequence is
      * whitespace, empty ("") or {@code null}, the value of {@code defaultStr}.</p>
      * 
-     * </p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
+     * <p>Whitespace is defined by {@link Character#isWhitespace(char)}.</p>
      *
      * <pre>
      * StringUtils.defaultIfBlank(null, "NULL")  = "NULL"


[2/5] [lang] LANG-1314: Fix javadoc creation on with Java 8

Posted by pa...@apache.org.
LANG-1314: Fix javadoc creation on with Java 8

Remove </p> tag from Computable's javadoc

The standard javadoc doclet does not allow self closing tags (such as
</p>). This patch removes such a tag from Computable's javadoc, as it's
redundant anyway, as it's only used to create spaces between two
existing paragraphs.


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/7337507a
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/7337507a
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/7337507a

Branch: refs/heads/master
Commit: 7337507a796ed6717feb87f4e9829467872c1741
Parents: 0f5c769
Author: pascalschumacher <pa...@gmx.net>
Authored: Mon Mar 6 19:23:00 2017 +0100
Committer: pascalschumacher <pa...@gmx.net>
Committed: Mon Mar 6 19:27:36 2017 +0100

----------------------------------------------------------------------
 src/main/java/org/apache/commons/lang3/concurrent/Computable.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/7337507a/src/main/java/org/apache/commons/lang3/concurrent/Computable.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/concurrent/Computable.java b/src/main/java/org/apache/commons/lang3/concurrent/Computable.java
index d9e5468..6cb37aa 100644
--- a/src/main/java/org/apache/commons/lang3/concurrent/Computable.java
+++ b/src/main/java/org/apache/commons/lang3/concurrent/Computable.java
@@ -18,7 +18,7 @@ package org.apache.commons.lang3.concurrent;
 
 /**
  * <p>Definition of an interface for a wrapper around a calculation that takes a single parameter and returns a result.</p>
- * <p/>
+ *
  * <p>This interface allows for wrapping a calculation into a class so that it maybe passed around an application.</p>
  *
  * @param <I> the type of the input to the calculation