You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2018/04/27 07:26:47 UTC
[1/6] james-project git commit: JAMES-2385 SetMessages $Draft check
needs to rely on KeywordsCombiner
Repository: james-project
Updated Branches:
refs/heads/master d4160c62f -> 560fd9051
JAMES-2385 SetMessages $Draft check needs to rely on KeywordsCombiner
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/c0b89b0f
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/c0b89b0f
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/c0b89b0f
Branch: refs/heads/master
Commit: c0b89b0f0a47f1ad6df02e374bc1b15a12d76f64
Parents: d4160c6
Author: benwa <bt...@linagora.com>
Authored: Tue Apr 24 11:02:48 2018 +0700
Committer: benwa <bt...@linagora.com>
Committed: Fri Apr 27 14:23:51 2018 +0700
----------------------------------------------------------------------
.../jmap/methods/SetMessagesUpdateProcessor.java | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/c0b89b0f/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/SetMessagesUpdateProcessor.java
----------------------------------------------------------------------
diff --git a/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/SetMessagesUpdateProcessor.java b/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/SetMessagesUpdateProcessor.java
index 822c387..69b114c 100644
--- a/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/SetMessagesUpdateProcessor.java
+++ b/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/SetMessagesUpdateProcessor.java
@@ -31,7 +31,6 @@ import java.util.stream.Collectors;
import java.util.stream.Stream;
import javax.inject.Inject;
-import javax.mail.Flags;
import javax.mail.MessagingException;
import javax.mail.Session;
import javax.mail.internet.MimeMessage;
@@ -39,11 +38,14 @@ import javax.mail.internet.MimeMessage;
import org.apache.james.core.MailAddress;
import org.apache.james.jmap.exceptions.DraftMessageMailboxUpdateException;
import org.apache.james.jmap.exceptions.InvalidOutboxMoveException;
+import org.apache.james.jmap.model.Keyword;
+import org.apache.james.jmap.model.Keywords;
import org.apache.james.jmap.model.MessageProperties;
import org.apache.james.jmap.model.SetError;
import org.apache.james.jmap.model.SetMessagesRequest;
import org.apache.james.jmap.model.SetMessagesResponse;
import org.apache.james.jmap.model.UpdateMessagePatch;
+import org.apache.james.jmap.utils.KeywordsCombiner;
import org.apache.james.jmap.utils.SystemMailboxesProvider;
import org.apache.james.mailbox.MailboxSession;
import org.apache.james.mailbox.MessageIdManager;
@@ -201,15 +203,18 @@ public class SetMessagesUpdateProcessor implements SetMessagesProcessor {
.collect(Guavate.toImmutableList());
List<MailboxId> targetMailboxes = getTargetedMailboxes(previousMailboxes, updateMessagePatch);
- boolean allMessagesWereDrafts = messagesToBeUpdated.stream()
+ boolean isDraft = messagesToBeUpdated.stream()
.map(MessageResult::getFlags)
- .allMatch(flags -> flags.contains(Flags.Flag.DRAFT));
+ .map(Keywords.factory().filterImapNonExposedKeywords()::fromFlags)
+ .reduce(new KeywordsCombiner())
+ .orElse(Keywords.DEFAULT_VALUE)
+ .contains(Keyword.DRAFT);
boolean targetContainsOutbox = targetMailboxes.stream().anyMatch(outboxMailboxes::contains);
boolean targetIsOnlyOutbox = targetMailboxes.stream().allMatch(outboxMailboxes::contains);
assertOutboxMoveTargetsOnlyOutBox(targetContainsOutbox, targetIsOnlyOutbox);
- assertOutboxMoveOriginallyHasDraftKeywordSet(targetContainsOutbox, allMessagesWereDrafts);
+ assertOutboxMoveOriginallyHasDraftKeywordSet(targetContainsOutbox, isDraft);
}
private void assertOutboxMoveTargetsOnlyOutBox(boolean targetContainsOutbox, boolean targetIsOnlyOutbox) {
@@ -218,8 +223,8 @@ public class SetMessagesUpdateProcessor implements SetMessagesProcessor {
}
}
- private void assertOutboxMoveOriginallyHasDraftKeywordSet(boolean targetIsOutbox, boolean allMessagesWereDrafts) {
- if (targetIsOutbox && !allMessagesWereDrafts) {
+ private void assertOutboxMoveOriginallyHasDraftKeywordSet(boolean targetIsOutbox, boolean isDraft) {
+ if (targetIsOutbox && !isDraft) {
throw new InvalidOutboxMoveException("Only message with `$Draft` keyword can be moved to Outbox");
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[6/6] james-project git commit: JAMES-2374 reverse {Add,
Remove}AddressMapping argument order in CLI help to match
implementation
Posted by bt...@apache.org.
JAMES-2374 reverse {Add,Remove}AddressMapping argument order in CLI help to match implementation
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/560fd905
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/560fd905
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/560fd905
Branch: refs/heads/master
Commit: 560fd90511ab0a92dc1c965899fefc350ab5cbb0
Parents: 308050d
Author: Matthieu Baechler <ma...@apache.org>
Authored: Tue Apr 24 16:11:11 2018 +0200
Committer: benwa <bt...@linagora.com>
Committed: Fri Apr 27 14:25:59 2018 +0700
----------------------------------------------------------------------
.../cli/src/main/java/org/apache/james/cli/type/CmdType.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/560fd905/server/container/cli/src/main/java/org/apache/james/cli/type/CmdType.java
----------------------------------------------------------------------
diff --git a/server/container/cli/src/main/java/org/apache/james/cli/type/CmdType.java b/server/container/cli/src/main/java/org/apache/james/cli/type/CmdType.java
index 02c0928..9e3dc3d 100644
--- a/server/container/cli/src/main/java/org/apache/james/cli/type/CmdType.java
+++ b/server/container/cli/src/main/java/org/apache/james/cli/type/CmdType.java
@@ -33,8 +33,8 @@ public enum CmdType {
LISTDOMAINS("ListDomains"),
LISTMAPPINGS("ListMappings"),
LISTUSERDOMAINMAPPINGS("ListUserDomainMappings", "user","domain"),
- ADDADDRESSMAPPING("AddAddressMapping", "user","domain", "fromAddress"),
- REMOVEADDRESSMAPPING("RemoveAddressMapping", "user","domain", "fromAddress"),
+ ADDADDRESSMAPPING("AddAddressMapping", "fromUser","fromDomain", "toAddress"),
+ REMOVEADDRESSMAPPING("RemoveAddressMapping", "fromUser","fromDomain", "toAddress"),
ADDREGEXMAPPING("AddRegexMapping", "user","domain", "regex"),
REMOVEREGEXMAPPING("RemoveRegexMapping", "user","domain", "regex"),
SETPASSWORD("SetPassword", "username","password"),
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[2/6] james-project git commit: JAMES-2382: Change the method name.
Posted by bt...@apache.org.
JAMES-2382: Change the method name.
The method is named "hasAnnotatedProperty" that is a query of asking whether the propertyDescriptor has the AnnotatedProperty or not.
Actually, the method returns an AnnotatedProperty found by the propertyDescriptor.
Thus, the method name "findAnnotatedProperty" should be intuitive than "hasAnnotatedProperty".
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/a66a8cf8
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/a66a8cf8
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/a66a8cf8
Branch: refs/heads/master
Commit: a66a8cf80e36685f336c90ec7b7197d4fd22e0fd
Parents: c0b89b0
Author: Kui LIU <br...@gmail.com>
Authored: Tue Apr 24 08:24:43 2018 +0200
Committer: benwa <bt...@linagora.com>
Committed: Fri Apr 27 14:24:55 2018 +0700
----------------------------------------------------------------------
.../lifecycle/osgi/AbstractOSGIAnnotationBeanPostProcessor.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/a66a8cf8/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/osgi/AbstractOSGIAnnotationBeanPostProcessor.java
----------------------------------------------------------------------
diff --git a/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/osgi/AbstractOSGIAnnotationBeanPostProcessor.java b/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/osgi/AbstractOSGIAnnotationBeanPostProcessor.java
index 6ec3d07..4bad5f5 100644
--- a/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/osgi/AbstractOSGIAnnotationBeanPostProcessor.java
+++ b/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/osgi/AbstractOSGIAnnotationBeanPostProcessor.java
@@ -178,7 +178,7 @@ public abstract class AbstractOSGIAnnotationBeanPostProcessor<A extends Annotati
MutablePropertyValues newprops = new MutablePropertyValues(pvs);
for (PropertyDescriptor pd : pds) {
- A s = hasAnnotatedProperty(pd);
+ A s = findAnnotatedProperty(pd);
if (s != null && !pvs.contains(pd.getName())) {
try {
logger.debug("Processing annotation [{}] for [{}.{}]", s, beanName, pd.getName());
@@ -267,7 +267,7 @@ public abstract class AbstractOSGIAnnotationBeanPostProcessor<A extends Annotati
}
- private A hasAnnotatedProperty(PropertyDescriptor propertyDescriptor) {
+ private A findAnnotatedProperty(PropertyDescriptor propertyDescriptor) {
Method setter = propertyDescriptor.getWriteMethod();
return setter != null ? AnnotationUtils.getAnnotation(setter, getAnnotation()) : null;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[5/6] james-project git commit: JAMES-2374 reverse {Add,
Remove}AddressMapping argument order in doc to match implementation
Posted by bt...@apache.org.
JAMES-2374 reverse {Add,Remove}AddressMapping argument order in doc to match implementation
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/308050d4
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/308050d4
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/308050d4
Branch: refs/heads/master
Commit: 308050d4f280f5200b8318da7345edf71a80dc21
Parents: ff1ff88
Author: Matthieu Baechler <ma...@apache.org>
Authored: Tue Apr 24 16:09:50 2018 +0200
Committer: benwa <bt...@linagora.com>
Committed: Fri Apr 27 14:25:58 2018 +0700
----------------------------------------------------------------------
src/site/markdown/server/manage-cli.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/308050d4/src/site/markdown/server/manage-cli.md
----------------------------------------------------------------------
diff --git a/src/site/markdown/server/manage-cli.md b/src/site/markdown/server/manage-cli.md
index fcb318f..ebfa1db 100644
--- a/src/site/markdown/server/manage-cli.md
+++ b/src/site/markdown/server/manage-cli.md
@@ -161,11 +161,11 @@ A mapping is a recipient rewritting rule. There is several kind of rewritting ru
- address mapping: rewrite a given mail address into an other one.
- regex mapping.
-You can manage address mapping like (redirects email from user@domain.tld to redirected@domain.new, then deletes the mapping):
+You can manage address mapping like (redirects email from fromUser@fromDomain.tld to redirected@domain.new, then deletes the mapping):
```
-{cli} AddAddressMapping redirected domain.new user@domain.tld
-{cli} RemoveAddressMapping redirected domain.new user@domain.tld
+{cli} AddAddressMapping fromUser fromDomain.tld redirected@domain.new
+{cli} RemoveAddressMapping fromUser fromDomain.tld redirected@domain.new
```
You can manage regex mapping like this:
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[4/6] james-project git commit: JAMES-2374 rename {add,
remove}AddressMapping argument to prevent ambiguity
Posted by bt...@apache.org.
JAMES-2374 rename {add,remove}AddressMapping argument to prevent ambiguity
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/ff1ff882
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/ff1ff882
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/ff1ff882
Branch: refs/heads/master
Commit: ff1ff8824a74a8c75a4163a3c72460125c2af5b4
Parents: 7d80a4c
Author: Matthieu Baechler <ma...@apache.org>
Authored: Tue Apr 24 16:06:37 2018 +0200
Committer: benwa <bt...@linagora.com>
Committed: Fri Apr 27 14:25:58 2018 +0700
----------------------------------------------------------------------
.../james/cli/probe/impl/JmxDataProbe.java | 8 +++---
.../org/apache/james/utils/DataProbeImpl.java | 10 ++++----
.../java/org/apache/james/probe/DataProbe.java | 4 +--
.../RecipientRewriteTableManagementMBean.java | 27 +++++++++-----------
.../lib/RecipientRewriteTableManagement.java | 12 ++++-----
5 files changed, 29 insertions(+), 32 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/ff1ff882/server/container/cli/src/main/java/org/apache/james/cli/probe/impl/JmxDataProbe.java
----------------------------------------------------------------------
diff --git a/server/container/cli/src/main/java/org/apache/james/cli/probe/impl/JmxDataProbe.java b/server/container/cli/src/main/java/org/apache/james/cli/probe/impl/JmxDataProbe.java
index dde2d88..fae65ac 100644
--- a/server/container/cli/src/main/java/org/apache/james/cli/probe/impl/JmxDataProbe.java
+++ b/server/container/cli/src/main/java/org/apache/james/cli/probe/impl/JmxDataProbe.java
@@ -173,24 +173,24 @@ public class JmxDataProbe implements DataProbe, JmxProbe {
}
@Override
- public void addAddressMapping(String user, String domain, String toAddress) throws Exception {
+ public void addAddressMapping(String fromUser, String fromDomain, String toAddress) throws Exception {
try (Closeable closeable =
MDCBuilder.create()
.addContext(MDCBuilder.PROTOCOL, JMX)
.addContext(MDCBuilder.ACTION, "addAddressMapping")
.build()) {
- virtualUserTableProxy.addAddressMapping(user, domain, toAddress);
+ virtualUserTableProxy.addAddressMapping(fromUser, fromDomain, toAddress);
}
}
@Override
- public void removeAddressMapping(String user, String domain, String fromAddress) throws Exception {
+ public void removeAddressMapping(String fromUser, String fromDomain, String toAddress) throws Exception {
try (Closeable closeable =
MDCBuilder.create()
.addContext(MDCBuilder.PROTOCOL, JMX)
.addContext(MDCBuilder.ACTION, "removeAddressMapping")
.build()) {
- virtualUserTableProxy.removeAddressMapping(user, domain, fromAddress);
+ virtualUserTableProxy.removeAddressMapping(fromUser, fromDomain, toAddress);
}
}
http://git-wip-us.apache.org/repos/asf/james-project/blob/ff1ff882/server/container/guice/guice-common/src/main/java/org/apache/james/utils/DataProbeImpl.java
----------------------------------------------------------------------
diff --git a/server/container/guice/guice-common/src/main/java/org/apache/james/utils/DataProbeImpl.java b/server/container/guice/guice-common/src/main/java/org/apache/james/utils/DataProbeImpl.java
index 38bc8ed..c5cab72 100644
--- a/server/container/guice/guice-common/src/main/java/org/apache/james/utils/DataProbeImpl.java
+++ b/server/container/guice/guice-common/src/main/java/org/apache/james/utils/DataProbeImpl.java
@@ -117,15 +117,15 @@ public class DataProbeImpl implements GuiceProbe, DataProbe {
}
@Override
- public void addAddressMapping(String user, String domain, String toAddress) throws Exception {
- MappingSource source = MappingSource.fromUser(user, domain);
+ public void addAddressMapping(String fromUser, String fromDomain, String toAddress) throws Exception {
+ MappingSource source = MappingSource.fromUser(fromUser, fromDomain);
recipientRewriteTable.addAddressMapping(source, toAddress);
}
@Override
- public void removeAddressMapping(String user, String domain, String fromAddress) throws Exception {
- MappingSource source = MappingSource.fromUser(user, domain);
- recipientRewriteTable.removeAddressMapping(source, fromAddress);
+ public void removeAddressMapping(String fromUser, String fromDomain, String toAddress) throws Exception {
+ MappingSource source = MappingSource.fromUser(fromUser, fromDomain);
+ recipientRewriteTable.removeAddressMapping(source, toAddress);
}
@Override
http://git-wip-us.apache.org/repos/asf/james-project/blob/ff1ff882/server/data/data-api/src/main/java/org/apache/james/probe/DataProbe.java
----------------------------------------------------------------------
diff --git a/server/data/data-api/src/main/java/org/apache/james/probe/DataProbe.java b/server/data/data-api/src/main/java/org/apache/james/probe/DataProbe.java
index c545d27..e85c06c 100644
--- a/server/data/data-api/src/main/java/org/apache/james/probe/DataProbe.java
+++ b/server/data/data-api/src/main/java/org/apache/james/probe/DataProbe.java
@@ -48,9 +48,9 @@ public interface DataProbe {
Mappings listUserDomainMappings(String user, String domain) throws Exception;
- void addAddressMapping(String user, String domain, String toAddress) throws Exception;
+ void addAddressMapping(String fromUser, String fromDomain, String toAddress) throws Exception;
- void removeAddressMapping(String user, String domain, String fromAddress) throws Exception;
+ void removeAddressMapping(String fromUser, String fromDomain, String toAddress) throws Exception;
void addRegexMapping(String user, String domain, String regex) throws Exception;
http://git-wip-us.apache.org/repos/asf/james-project/blob/ff1ff882/server/data/data-api/src/main/java/org/apache/james/rrt/api/RecipientRewriteTableManagementMBean.java
----------------------------------------------------------------------
diff --git a/server/data/data-api/src/main/java/org/apache/james/rrt/api/RecipientRewriteTableManagementMBean.java b/server/data/data-api/src/main/java/org/apache/james/rrt/api/RecipientRewriteTableManagementMBean.java
index 75e4dee..30dac12 100644
--- a/server/data/data-api/src/main/java/org/apache/james/rrt/api/RecipientRewriteTableManagementMBean.java
+++ b/server/data/data-api/src/main/java/org/apache/james/rrt/api/RecipientRewriteTableManagementMBean.java
@@ -57,31 +57,28 @@ public interface RecipientRewriteTableManagementMBean {
void removeRegexMapping(String user, String domain, String regex) throws Exception;
/***
- * Add address mapping
+ * Add address mapping that, for a user from@fromDomain would redirect
+ * mails to toAddress
*
- * @param user
+ * @param fromUser
* the username. Null if no username should be used
- * @param domain
+ * @param fromDomain
* the domain. Null if no domain should be used
- * @param address
+ * @param toAddress
* the address.
- * @throws Exception
- * If an error occurred
*/
- void addAddressMapping(String user, String domain, String address) throws Exception;
+ void addAddressMapping(String fromUser, String fromDomain, String toAddress) throws Exception;
/**
- * Remove address mapping
- *
- * @param user
+ * Remove address mapping. The API takes the same arguments as addAddressMapping
+ *
+ * @param fromUser
* the username. Null if no username should be used
- * @param domain
+ * @param fromDomain
* the domain. Null if no domain should be used
- * @param address
- * @throws Exception
- * If an error occurred
+ * @param toAddress
*/
- void removeAddressMapping(String user, String domain, String address) throws Exception;
+ void removeAddressMapping(String fromUser, String fromDomain, String toAddress) throws Exception;
/**
* Add error mapping
http://git-wip-us.apache.org/repos/asf/james-project/blob/ff1ff882/server/data/data-library/src/main/java/org/apache/james/rrt/lib/RecipientRewriteTableManagement.java
----------------------------------------------------------------------
diff --git a/server/data/data-library/src/main/java/org/apache/james/rrt/lib/RecipientRewriteTableManagement.java b/server/data/data-library/src/main/java/org/apache/james/rrt/lib/RecipientRewriteTableManagement.java
index 9ee4bb5..ecc7b17 100644
--- a/server/data/data-library/src/main/java/org/apache/james/rrt/lib/RecipientRewriteTableManagement.java
+++ b/server/data/data-library/src/main/java/org/apache/james/rrt/lib/RecipientRewriteTableManagement.java
@@ -57,15 +57,15 @@ public class RecipientRewriteTableManagement extends StandardMBean implements Re
}
@Override
- public void addAddressMapping(String user, String domain, String address) throws RecipientRewriteTableException {
- MappingSource source = MappingSource.fromUser(user, domain);
- rrt.addAddressMapping(source, address);
+ public void addAddressMapping(String fromUser, String fromDomain, String toAddress) throws RecipientRewriteTableException {
+ MappingSource source = MappingSource.fromUser(fromUser, fromDomain);
+ rrt.addAddressMapping(source, toAddress);
}
@Override
- public void removeAddressMapping(String user, String domain, String address) throws RecipientRewriteTableException {
- MappingSource source = MappingSource.fromUser(user, domain);
- rrt.removeAddressMapping(source, address);
+ public void removeAddressMapping(String fromUser, String fromDomain, String toAddress) throws RecipientRewriteTableException {
+ MappingSource source = MappingSource.fromUser(fromUser, fromDomain);
+ rrt.removeAddressMapping(source, toAddress);
}
@Override
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[3/6] james-project git commit: JAMES-2378 Enforce immutable list
usage when logging
Posted by bt...@apache.org.
JAMES-2378 Enforce immutable list usage when logging
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/7d80a4c2
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/7d80a4c2
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/7d80a4c2
Branch: refs/heads/master
Commit: 7d80a4c2391ed403a98979366ac815d9fffc7110
Parents: a66a8cf
Author: benwa <bt...@linagora.com>
Authored: Fri Apr 20 18:17:24 2018 +0700
Committer: benwa <bt...@linagora.com>
Committed: Fri Apr 27 14:25:22 2018 +0700
----------------------------------------------------------------------
.../org/apache/james/jmap/methods/SetMessagesUpdateProcessor.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/7d80a4c2/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/SetMessagesUpdateProcessor.java
----------------------------------------------------------------------
diff --git a/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/SetMessagesUpdateProcessor.java b/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/SetMessagesUpdateProcessor.java
index 69b114c..9be8e39 100644
--- a/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/SetMessagesUpdateProcessor.java
+++ b/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/SetMessagesUpdateProcessor.java
@@ -324,7 +324,7 @@ public class SetMessagesUpdateProcessor implements SetMessagesProcessor {
}
private void handleInvalidRequest(SetMessagesResponse.Builder responseBuilder, MessageId messageId,
- List<ValidationResult> validationErrors) {
+ ImmutableList<ValidationResult> validationErrors) {
LOGGER.warn("Invalid update request for message #{}: {}", messageId, validationErrors);
String formattedValidationErrorMessage = validationErrors.stream()
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org