[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #20742: [Chore](runtime-filter) do not make query fail when rf publish failed

["BiteTheDDDDt (via GitHub)" <gi...@apache.org>]

BiteTheDDDDt commented on code in PR #20742:
URL: https://github.com/apache/doris/pull/20742#discussion_r1227722040


##########
be/src/exprs/runtime_filter_slots.h:
##########
@@ -220,7 +220,11 @@ class RuntimeFilterSlotsBase {
     Status publish() {
         for (auto& pair : _runtime_filters) {
             for (auto filter : pair.second) {
-                RETURN_IF_ERROR(filter->publish());
+                auto state = filter->publish();
+                if (!state) {
+                    // TODO: solve publish failed when scan not schedured
+                    LOG(WARNING) << "filter publish failed, reason=" << state.to_string();

Review Comment:
   Even if rf publish failed, the query should execute normally.
   I changed this behavior in #20593 to cause the workflow to be blocked, now change it back



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org