[GitHub] [incubator-doris] zuochunwei commented on a change in pull request #7131: Refactor olap scannode

[GitBox <gi...@apache.org>]

zuochunwei commented on a change in pull request #7131:
URL: https://github.com/apache/incubator-doris/pull/7131#discussion_r755842952



##########
File path: be/src/runtime/fragment_mgr.h
##########
@@ -58,7 +58,7 @@ class FragmentMgr : public RestMonitorIface {
     using FinishCallback = std::function<void(PlanFragmentExecutor*)>;
 
     FragmentMgr(ExecEnv* exec_env);
-    virtual ~FragmentMgr();
+    virtual ~FragmentMgr();//why virtual dtor?

Review comment:
       just delete the empty implement of virtual ~FragmentMgr，you should implement dtor if op= and copy ctor are necessary also. otherwise not implement accord the 3 rules




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org