[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #23: Set default version in release script

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #23: Set default version in release script
URL: https://github.com/apache/skywalking-cli/pull/23#discussion_r355112574
 
 

 ##########
 File path: Makefile
 ##########
 @@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-VERSION ?= latest
+VERSION ?= 0.1.0
 
 Review comment:
   > I think we should set it to 0.2.0-latest?
   
   > In traditional, we should follow the pattern, version + snapshot/latest/commit id as dev version. 0.1.0， 0.2.0 should only work for release, right?
   
   I prefer `0.2.0-snapshot`
   
   > And with a real release script to override this?
   
   Now the `makefile` serves as release script, if we add a release script, then the version in that script should be updated in every release? say `sh release.sh --version=0.2.0`, I don't think it's different from `make VERSION=0.2.0 release`.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services