[GitHub] [iceberg] rdblue commented on a diff in pull request #4612: Core:Optimize Error msg in validateDeletedManifests (fix #3466)

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #4612:
URL: https://github.com/apache/iceberg/pull/4612#discussion_r857160120


##########
core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java:
##########
@@ -257,7 +257,10 @@ private void validateDeletedManifests(Set<ManifestFile> currentManifests) {
         .filter(manifest -> !currentManifests.contains(manifest))
         .findAny()
         .ifPresent(manifest -> {
-          throw new ValidationException("Manifest is missing: %s", manifest.path());
+          throw new ValidationException("Cannot commit RewriteManifests; " +
+                  "manifests that existed at the beginning of this rewrite have already been removed by another " +
+                  "operation. Manifest %s, which would be replaced by this operation, has already been removed.",
+                  manifest.path());

Review Comment:
   I think this is too long to be an effective error message. I think your intent is to tell the end user that something changed. But there isn't anything that user can do besides retry the operation. I think the short message works fine, but you could also extend it to "Manifest is missing: %s (table changed concurrently)". That's more clear without being confusing or overly long.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org