You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by co...@apache.org on 2016/04/28 05:06:53 UTC
incubator-zeppelin git commit: ZEPPELIN-824 - Make CI Crash when
there is jshint errors
Repository: incubator-zeppelin
Updated Branches:
refs/heads/master c8c26b53b -> ec661d7c1
ZEPPELIN-824 - Make CI Crash when there is jshint errors
### What is this PR for?
This PR has for goal to fix the CI build regarding the front-end.
The CI is currently not failing due to jshint, even though it fails locally with a `grunt build`
There was two issues making this behaviour:
* Jshint was called only on newer files in build
* Mvn is using --force on grunt
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-824
### How should this be tested?
Make a jshint error (!= instead of !== for example)
then run `mvn package` inside the zeppelin-web forlder
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Damien CORNEAU <co...@gmail.com>
Closes #854 from corneadoug/fix/FrontEndCIBuild and squashes the following commits:
afbcea4 [Damien CORNEAU] Make CI Crash when there is jshint errors
Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/ec661d7c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/ec661d7c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/ec661d7c
Branch: refs/heads/master
Commit: ec661d7c1a64c3c157cc11753f463da9d035cbd0
Parents: c8c26b5
Author: Damien CORNEAU <co...@gmail.com>
Authored: Mon Apr 25 11:48:21 2016 +0900
Committer: Damien CORNEAU <co...@gmail.com>
Committed: Thu Apr 28 12:06:33 2016 +0900
----------------------------------------------------------------------
zeppelin-web/Gruntfile.js | 2 +-
zeppelin-web/pom.xml | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/ec661d7c/zeppelin-web/Gruntfile.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/Gruntfile.js b/zeppelin-web/Gruntfile.js
index 906c142..ce62d8b 100644
--- a/zeppelin-web/Gruntfile.js
+++ b/zeppelin-web/Gruntfile.js
@@ -434,7 +434,7 @@ module.exports = function (grunt) {
]);
grunt.registerTask('build', [
- 'newer:jshint',
+ 'jshint:all',
'clean:dist',
'wiredep',
'useminPrepare',
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/ec661d7c/zeppelin-web/pom.xml
----------------------------------------------------------------------
diff --git a/zeppelin-web/pom.xml b/zeppelin-web/pom.xml
index 2c46c76..0e54d65 100644
--- a/zeppelin-web/pom.xml
+++ b/zeppelin-web/pom.xml
@@ -124,7 +124,6 @@
</goals>
<configuration>
<arguments>build</arguments>
- <arguments>--force</arguments>
</configuration>
</execution>