[GitHub] zhreshold commented on a change in pull request #12051: [MXNET-780][WIP] Fix exception handling bug

[GitBox <gi...@apache.org>]

zhreshold commented on a change in pull request #12051: [MXNET-780][WIP] Fix exception handling bug
URL: https://github.com/apache/incubator-mxnet/pull/12051#discussion_r212749685
 
 

 ##########
 File path: src/io/iter_image_det_recordio.cc
 ##########
 @@ -237,53 +237,53 @@ class ImageDetRecordIOParser {
   std::unique_ptr<ImageDetLabelMap> label_map_;
   /*! \brief temp space */
   mshadow::TensorContainer<cpu, 3> img_;
+  /*! \brief OMPException obj to store and rethrow exceptions from omp blocks*/
+  dmlc::OMPException omp_exc_;
 };
 
-template<typename DType>
+template <typename DType>
 inline void ImageDetRecordIOParser<DType>::Init(
-    const std::vector<std::pair<std::string, std::string> >& kwargs) {
+    const std::vector<std::pair<std::string, std::string>> &kwargs) {
 
 Review comment:
   The space is left deliberately for compatibility with some compilers, don't remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services