You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/27 10:34:25 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4238: Don't use __attribute__ in source code directly

xiaoxiang781216 opened a new pull request #4238:
URL: https://github.com/apache/incubator-nuttx/pull/4238


   ## Summary
   
   - Replace all __attribute__((aligned(x)) with aligned_data(x)
   - Replace all __attribute__((section(x)) with locate_data(x)
   
   ## Impact
   
   Same as before after macro expansion
   
   ## Testing
   
   Pass the CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #4238: Don't use __attribute__ in source code directly

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #4238:
URL: https://github.com/apache/incubator-nuttx/pull/4238#issuecomment-887535579


   Please the nxstyle warning due the heavy maco used in include/nuttx/tree.h:
   ```
   include/nuttx/tree.h:317:23: error: Multiple data definitions
   include/nuttx/tree.h:330:14: error: Garbage follows right bracket
   include/nuttx/tree.h:338:18: error: Garbage follows right bracket
   include/nuttx/tree.h:339:12: error: Garbage follows right bracket
   include/nuttx/tree.h:342:10: error: Garbage follows right bracket
   include/nuttx/tree.h:349:14: error: Garbage follows right bracket
   include/nuttx/tree.h:357:18: error: Garbage follows right bracket
   include/nuttx/tree.h:358:14: error: Garbage follows right bracket
   include/nuttx/tree.h:361:10: error: Garbage follows right bracket
   include/nuttx/tree.h:362:6: error: Garbage follows right bracket
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] gustavonihei merged pull request #4238: Don't use __attribute__ in source code directly

Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #4238:
URL: https://github.com/apache/incubator-nuttx/pull/4238


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4238: Don't use __attribute__ in source code directly

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4238:
URL: https://github.com/apache/incubator-nuttx/pull/4238#issuecomment-888479596


   The change is intentional, you can review it separately here:
   https://github.com/apache/incubator-nuttx/pull/4238/commits/14582e1fc4afb08039e248a0ea0cfb8e1751d70d


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4238: Don't use __attribute__ in source code directly

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4238:
URL: https://github.com/apache/incubator-nuttx/pull/4238#issuecomment-889405281


   Ok, I drop that patch from PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4238: Don't use __attribute__ in source code directly

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4238:
URL: https://github.com/apache/incubator-nuttx/pull/4238#issuecomment-888481543


   Rebase to fix the conflict, no really change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4238: Don't use __attribute__ in source code directly

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4238:
URL: https://github.com/apache/incubator-nuttx/pull/4238#issuecomment-887535579


   Please the nxstyle warning due the heavy maco used in include/nuttx/tree.h:
   ````
   include/nuttx/tree.h:317:23: error: Multiple data definitions
   include/nuttx/tree.h:330:14: error: Garbage follows right bracket
   include/nuttx/tree.h:338:18: error: Garbage follows right bracket
   include/nuttx/tree.h:339:12: error: Garbage follows right bracket
   include/nuttx/tree.h:342:10: error: Garbage follows right bracket
   include/nuttx/tree.h:349:14: error: Garbage follows right bracket
   include/nuttx/tree.h:357:18: error: Garbage follows right bracket
   include/nuttx/tree.h:358:14: error: Garbage follows right bracket
   include/nuttx/tree.h:361:10: error: Garbage follows right bracket
   include/nuttx/tree.h:362:6: error: Garbage follows right bracket
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4238: Don't use __attribute__ in source code directly

Posted by GitBox <gi...@apache.org>.
gustavonihei commented on pull request #4238:
URL: https://github.com/apache/incubator-nuttx/pull/4238#issuecomment-889379511


   > The change is intentional, you can review it separately here:
   > [14582e1](https://github.com/apache/incubator-nuttx/commit/14582e1fc4afb08039e248a0ea0cfb8e1751d70d)
   
   The change is not related to this PR, so I think it should be left out.
   This function is probably not built by any CI configuration, because this `USB_DmaDesc` symbol seems to come from the vendor's BSP. Another evidence is the `epph` on the below line, which contains a typo and should be `epphy`.
   
   If we simply remove that single line it will probably make someone's life more difficult to track an eventual bug on this driver.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org