You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/01 16:31:22 UTC
[GitHub] [hive] ashutoshc commented on a change in pull request #1118: HIVE-23363: Upgrade DataNucleus dependency to 5.2
ashutoshc commented on a change in pull request #1118:
URL: https://github.com/apache/hive/pull/1118#discussion_r448480980
##########
File path: standalone-metastore/metastore-server/src/main/resources/package.jdo
##########
@@ -345,20 +345,20 @@
<datastore-identity>
<column name="CD_ID"/>
</datastore-identity>
- <field name="cols" table="COLUMNS_V2" >
Review comment:
Can you describe the need for this change?
##########
File path: standalone-metastore/metastore-server/src/main/resources/package.jdo
##########
@@ -345,20 +345,20 @@
<datastore-identity>
<column name="CD_ID"/>
</datastore-identity>
- <field name="cols" table="COLUMNS_V2" >
+ <field name="cols" persistence-modifier="persistent" table="COLUMNS_V2">
<collection element-type="MFieldSchema"/>
- <foreign-key name="COLUMNS_V2_FK" delete-action="cascade"/>
<join>
- <primary-key name="COLUMNS_PK">
Review comment:
Any reason to change the name here?
##########
File path: standalone-metastore/metastore-server/src/main/resources/package.jdo
##########
@@ -345,20 +345,20 @@
<datastore-identity>
<column name="CD_ID"/>
</datastore-identity>
- <field name="cols" table="COLUMNS_V2" >
+ <field name="cols" persistence-modifier="persistent" table="COLUMNS_V2">
<collection element-type="MFieldSchema"/>
- <foreign-key name="COLUMNS_V2_FK" delete-action="cascade"/>
Review comment:
We do want cascade-delete here. Any reason to remove it?
##########
File path: standalone-metastore/metastore-server/src/main/resources/package.jdo
##########
@@ -345,20 +345,20 @@
<datastore-identity>
<column name="CD_ID"/>
</datastore-identity>
- <field name="cols" table="COLUMNS_V2" >
+ <field name="cols" persistence-modifier="persistent" table="COLUMNS_V2">
<collection element-type="MFieldSchema"/>
- <foreign-key name="COLUMNS_V2_FK" delete-action="cascade"/>
<join>
- <primary-key name="COLUMNS_PK">
+ <primary-key name="SQL110922153006740">
+ <column name="CD_ID"/>
Review comment:
This probably is fine to do. Though, was it necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org