You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/07/13 18:47:19 UTC

[GitHub] [incubator-eventmesh] yzhao244 opened a new issue #435: Expose clientmanager/admin APIs as RESTful APIs

yzhao244 opened a new issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435


   ## Enhancement Request
   
   <!-- 
   First of all: Have you checked the docs https://github.com/apache/incubator-eventmesh/tree/develop/docs, 
   or GitHub issues whether someone else has already reported your issue? 
   -->
   
   ### Is your enhancement request related to a problem? Please describe
   
   Yes,  the clientmanager/admin APIs which are exposed from eventmesh-runtime module are not following the best practice of RESTful APIs . The problems could be seen by API urls such as "showClient", "rejectAllClient" ,"redirectClientByPath"
   
   <!-- 
   A clear and concise description of what the enhancement is.
   -->
   
   ### Describe the solution you'd like
   
   Add a new module such as eventmesh-rest which optimizes the existing admin/clientmanager APIs and expose them as RESTful APIs. 
   <!-- 
   A clear and concise description of what you want to happen. Add any considered drawbacks.
   -->
   
   ### Describe alternatives you've considered
   I will follow up and provide more details later. However, I would like to report this to the community and initiate a discussion here. :) . Please provide your feedbacks. 
   <!-- 
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   ### Additional context
   
   <!-- 
   Add any other context or screenshots about the enhancement request here.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 closed issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] yzhao244 commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
yzhao244 commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-911779616


   @ruanwenjun @qqeasonchen @JunjieChou I agree with eventmesh-admin module, sounds a very good idea. eventmesh-admin module can in the future becomes a management layer which exposes Admin or Schema REST APIs to UI console for end-user to do managements. 
   
   I can rework my existing PR #513 to create eventmesh-admin module. Just double confirm, I will name this new module as "eventmesh-admin" instead of "eventmesh-admim-plugin", am I right? :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-892747626


   @yzhao244 Is there any updates here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] ruanwenjun commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-911329870


   @yzhao244 @qqeasonchen The topology may look like below, this is a simple demo, the eventmesh-runtime is decentralization and ligntwight. For third-part storage, we may only need to rely on registry center,
   ![image](https://user-images.githubusercontent.com/22415594/131803530-0d2551b7-7a48-4345-a5aa-aba1e441776b.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] yzhao244 commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
yzhao244 commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-910287867


   @JunjieChou Great suggestions actually :) . Btw, I am planning contributing eventmesh-openschema-rest module along with a readme file and maybe some skeleton code under the main eventmesh-openschema-plugin module
   
   for example, eventmesh-openschema-plugin/eventmesh-openschema-rest/readme.md which contains my proposed details of EventMesh Schema Registry REST APIs such as REST URL, payload and examples.  
   eventmesh-openschema-plugin/eventmesh-openschema-rest/.../controller/SchemaRegistryController.java which only contains some skeleton codes.
   
   I will notify you as soon as I have a PR ready. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] yzhao244 edited a comment on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
yzhao244 edited a comment on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-906419129


   > Hi, @yzhao244. I would like to coorperate with you on Open Schema related coding part. Any updates here?
   
   Sure, I would like to cooperate with you on the coding part. :) . I read your committed design documentation for OpenSchema. It is pretty good.  Oh,btw, do you have any plan of laying out a new module/class structure for OpenSchema integration such as new module/plugin/class and so on? We can work together to commit a very high-level structures to EventMesh and then work our way down to specific implementations. :) ..My understanding so far is that I think we are good at the design of providing Schema Registry capability in EventMesh which follows OpenSchema standards for providing CRUD against schema. Regarding, validation/Id generation/attachment may be still under discussion. Therefore, maybe we can focus on the Schema Registry part for now. 
   
   WDYT? and please let me know if I misunderstood anything lol.. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-879510268


   good suggestions, just go ahead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-884747427


   @yzhao244 I think you can submit this pr first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] JunjieChou commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
JunjieChou commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-906514666


   @yzhao244 
   Glad to hear that, I think it's great! 😊
   
   I couldn't agree with you more that we could focus on the Schema Registry based on what you have done currently. Besides, I have generally scanned your committed code on ```yuridev``` branch and I believe it has provided a thorough solution and supported much API from OpenSchema. But I need to catch more on ```h2-database``` and ```jackson``` to move forward.
   
   In my forked repository, I plan to create a new module ```eventmesh-openschema-plugin```, serving as the plugin for validation/cache/interaction(with schema registry)/... . But a specific class structure is to be determined. 
   
   In the future, I have two suggestions:
   - First, we might combine validation/cache/interaction and schema registry into one plugin, in which ```SchemaServiceImpl.class``` is implemented locally.
   - Second, we might extract schema registry as a separated RESTful service and implement another SchemaService based on HTTP.
   
   While as I can see upwards, you have been working on such HTTP-based implementation πŸ‘ , so I would like to be noticed if there are any updates. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] yzhao244 commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
yzhao244 commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-897960548


   HttpServer is still created and run inside eventmensh-runtime. Only the server.createContext part and handlers move to eventmesh-rest module. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] JunjieChou edited a comment on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
JunjieChou edited a comment on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-906514666


   @yzhao244 
   Glad to hear that, I think it's great! 😊
   
   I couldn't agree with you more that we could focus on the Schema Registry based on what you have done currently. Besides, I have generally scanned your committed code on ```yuridev``` branch and I believe it has provided a thorough solution and supported much API from OpenSchema. But I need to catch more on ```h2-database``` and ```jackson``` to move forward.
   
   In my forked repository, I plan to create a new module ```eventmesh-openschema-plugin```, serving as the plugin for validation/cache/interaction(with schema registry)/... . But a specific class structure is to be determined. 
   
   In the future, I have two suggestions:
   - First, we might combine validation/cache/interaction and schema registry into one plugin, in which ```SchemaServiceImpl.class``` is implemented locally.
   - Second, we might extract schema registry as a separated RESTful service and implement another SchemaService based on HTTP.
   
   While as I can see upwards, you have been working on such HTTP-based implementation πŸ‘ , so I would like to be notified if there are any updates. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] yzhao244 commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
yzhao244 commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-912750866


   @ruanwenjun Based on your topology image above, do you think schema registry should be a child module of eventmesh-admin?
   
   For example
   eventmesh-admin/eventmesh-admin-schemaregistry
   eventmesh-admin/eventmesh-admin-clientmanager


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] JunjieChou commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
JunjieChou commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-910366678


   @yzhao244 Hi, good to hear that you are going to start a readme file.
   
   Actually, I have started the coding of the separated RESTful Schema Registry. 
   
   Inspired by what you have coded, I created a new module called ```OpenSchemaRegistry``` under ```eventmesh-openschema-plugin``` as a separate service based on Spring-boot and spring-data-jpa. 
   
   For now, I have accomplished the ```/schemas```  controller. Let me pull a request later. I am newly to these frameworks and welcome reviews and suggestions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] yzhao244 commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
yzhao244 commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-914348558


   > @yzhao244 I think we can leave the plugins out for now, we can just add an admin module.
   
   Sounds good. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-898096374


   @yzhao244 thanks, you can see the new pr #498 , maybe you can give some updates as well, after all, you are the first contributor of this feature :), i hope you can be continue on this, thanks again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] JunjieChou commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
JunjieChou commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-910408804


   @yzhao244 I have created a pr to your forked repository. Hope for reviewing 😊 !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] github-actions[bot] commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-879318391


   Welcome to the Apache EventMesh (incubating) community!!
   We are glad that you are contributing by opening this issue. :D
   
   Please make sure to include all the relevant context.
   We will be here shortly.
   
   If you are interested in contributing to our project, please let us know!
   You can check out our contributing guide on [contributing to EventMesh](https://github.com/apache/incubator-eventmesh/blob/develop/CONTRIBUTING.md).
   
   Want to get closer to the community?
   
   WeChat Group:
   ![wechat_qr](https://github.com/apache/incubator-eventmesh/blob/develop/docs/images/mesh-helper.png?raw=true)
   
   Mailing Lists:
   | Name | Description |Subscribe	|Unsubscribe|Archive
   | ----    | ----    |----    | ----    | ----    |
   |Users	|User support and questions mailing list|	[Subscribe](mailto:users-subscribe@eventmesh.incubator.apache.org)	|[Unsubscribe](mailto:users-unsubscribe@eventmesh.incubator.apache.org)	|[Mail Archives](https://lists.apache.org/list.html?users@eventmesh.apache.org)|
   |Development	|Development related discussions|	[Subscribe](mailto:dev-subscribe@eventmesh.incubator.apache.org)	|[Unsubscribe](mailto:dev-unsubscribe@eventmesh.incubator.apache.org)	|[Mail Archives](https://lists.apache.org/list.html?dev@eventmesh.apache.org)|
   |Commits	|All commits to repositories|	[Subscribe](mailto:commits-subscribe@eventmesh.incubator.apache.org)	|[Unsubscribe](mailto:commits-unsubscribe@eventmesh.incubator.apache.org)	|[Mail Archives](https://lists.apache.org/list.html?commits@eventmesh.apache.org)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] ruanwenjun commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-910961945


   @yzhao244 I agree with using SpringBoot, since we may need to add a new module such like admin-server, it works as a control plane and provide some interface to manage the eventmesh-runtime module and other configuration(e.g. schema).
   SpringBoot can help us a lot, and in runtime-module, I think we may don't need to import spring dependency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-911285252


   I think eventmesh-admin moudle is great.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] ruanwenjun commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-913290759


   @yzhao244 I think we can leave the plugins out for now, we can just add an admin module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] yzhao244 commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
yzhao244 commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-897959346


   @qqeasonchen Yes,  Basically, my idea is to move httpserver context creation, handlers along with its dependencies such as Utils classes to eventmesh-rest module.  Inside the module, a new utility class called "RequestMapping" maps RESTful RequestUrl to the corresponding handler method and extracts values from path variables. As my sample handler class code indicates, any request invokes REST API "/schemaregistry/subjects/{subject}/versions" eventually calls createSchemaHandler method. Additionally, subject value is extracted from the path variable {subject} and passed to handler method as well.   
   
   ![image](https://user-images.githubusercontent.com/15642771/129267814-3e01eac8-d925-40db-bc87-0e53cc4cf28e.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] yzhao244 commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
yzhao244 commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-906419129


   > Hi, @yzhao244. I would like to coorperate with you on Open Schema related coding part. Any updates here?
   Sure, I would like to cooperate with you on the coding part. :) . I read your committed design documentation for OpenSchema. It is pretty good.  Oh,btw, do you have any plan of laying out a new module/class structure for OpenSchema integration such as new module/plugin/class and so on? We can work together to commit a very high-level structures to EventMesh and then work our way down to specific implementations. :) ..My understanding so far is that I think we are good at the design of providing Schema Registry capability in EventMesh which follows OpenSchema standards for providing CRUD against schema. Regarding, validation/Id generation/attachment may be still under discussion. Therefore, maybe we can focus on the Schema Registry part for now. 
   
   WDYT? and please let me know if I misunderstood anything lol.. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] JunjieChou commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
JunjieChou commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-904583244


   Hi, @yzhao244. I would like to coorperate with you on Open Schema related coding part. Any updates here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-892747626


   @yzhao244 Is there any updates here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] yzhao244 commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
yzhao244 commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-910450675


   @JunjieChou Sure, I can definitely review. :) . Btw, did you have a chance to discuss with the community of using SpringBoot and Spring JPA for Schema Registry in EventMesh project. Maybe we can add Eason and other members to this issue to have an open discussion. :) 
   
   My initial thought was exposing Schema Registry REST APIs by leveraging the current EventMesh's ClientManagerController's design of using HttpServer.createContext(""). However, modifying the url and handlers to make the APIs more RESTful without using another Framework. Basically, Schema Registry and Runtime run on the same server. Therefore, I wasn't thinking of adding another framework to EventMesh.
   
   Anyways, I can share some implementations with the community and it could be just my personal thought. lol
   
   @qqeasonchen @ruanwenjun @jinrongluo WDYT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] qqeasonchen commented on issue #435: Expose clientmanager/admin APIs as RESTful APIs

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on issue #435:
URL: https://github.com/apache/incubator-eventmesh/issues/435#issuecomment-879510827


   #346 #349 are related to this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org