You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "HolyLow (via GitHub)" <gi...@apache.org> on 2025/08/20 02:20:03 UTC
[PR] [CELEBORN-2115][CIP-14] Support PushData in cppClient [celeborn]
HolyLow opened a new pull request, #3434:
URL: https://github.com/apache/celeborn/pull/3434
### What changes were proposed in this pull request?
Support PushData network message in cppClient.
### Why are the changes needed?
PushData is the network message of writing to cppClient.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Compilation and UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2115][CIP-14] Support PushData in cppClient [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #3434: [CELEBORN-2115][CIP-14] Support PushData in cppClient
URL: https://github.com/apache/celeborn/pull/3434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2115][CIP-14] Support PushData in cppClient [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3434:
URL: https://github.com/apache/celeborn/pull/3434#discussion_r2292587050
##########
cpp/celeborn/network/tests/MessageTest.cpp:
##########
@@ -153,3 +153,34 @@ TEST(MessageTest, decodeChunkFetchFailure) {
EXPECT_EQ(streamChunkSlice.len, len);
EXPECT_EQ(chunkFetchFailure->errorMsg(), failureMsg);
}
+
+TEST(MessageTest, encodePushData) {
+ const std::string body = "test-body";
+ auto bodyBuffer = memory::ByteBuffer::createWriteOnly(body.size());
+ bodyBuffer->writeFromString(body);
+ const long requestId = 1000;
+ const uint8_t mode = 2;
Review Comment:
Is it better to use 0 or 1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2115][CIP-14] Support PushData in cppClient [celeborn]
Posted by "HolyLow (via GitHub)" <gi...@apache.org>.
HolyLow commented on code in PR #3434:
URL: https://github.com/apache/celeborn/pull/3434#discussion_r2292603275
##########
cpp/celeborn/network/tests/MessageTest.cpp:
##########
@@ -153,3 +153,34 @@ TEST(MessageTest, decodeChunkFetchFailure) {
EXPECT_EQ(streamChunkSlice.len, len);
EXPECT_EQ(chunkFetchFailure->errorMsg(), failureMsg);
}
+
+TEST(MessageTest, encodePushData) {
+ const std::string body = "test-body";
+ auto bodyBuffer = memory::ByteBuffer::createWriteOnly(body.size());
+ bodyBuffer->writeFromString(body);
+ const long requestId = 1000;
+ const uint8_t mode = 2;
Review Comment:
It makes no difference as the UT only tests if the corresponding value is encoded/decoded correctly. The value doesn't have to contain any meaningful value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2115][CIP-14] Support PushData in cppClient [celeborn]
Posted by "HolyLow (via GitHub)" <gi...@apache.org>.
HolyLow commented on code in PR #3434:
URL: https://github.com/apache/celeborn/pull/3434#discussion_r2292603275
##########
cpp/celeborn/network/tests/MessageTest.cpp:
##########
@@ -153,3 +153,34 @@ TEST(MessageTest, decodeChunkFetchFailure) {
EXPECT_EQ(streamChunkSlice.len, len);
EXPECT_EQ(chunkFetchFailure->errorMsg(), failureMsg);
}
+
+TEST(MessageTest, encodePushData) {
+ const std::string body = "test-body";
+ auto bodyBuffer = memory::ByteBuffer::createWriteOnly(body.size());
+ bodyBuffer->writeFromString(body);
+ const long requestId = 1000;
+ const uint8_t mode = 2;
Review Comment:
It makes no difference as the UT only tests if the corresponding value is encoded/decoded correctly. The value doesn't have to be meaningful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2115][CIP-14] Support PushData in cppClient [celeborn]
Posted by "HolyLow (via GitHub)" <gi...@apache.org>.
HolyLow commented on PR #3434:
URL: https://github.com/apache/celeborn/pull/3434#issuecomment-3203931976
@SteNicholas @FMX @RexXiong Could you kindly help review this PR? Thanks a lot.
Any suggestion is welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org