You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/14 07:47:05 UTC
[GitHub] [pulsar] RobertIndie commented on a change in pull request #14671: Fix normal topic named ends with `healthcheck` becomes system topic issue.
RobertIndie commented on a change in pull request #14671:
URL: https://github.com/apache/pulsar/pull/14671#discussion_r825651614
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/systopic/SystemTopicClientTest.java
##########
@@ -22,30 +22,55 @@
import static org.apache.pulsar.common.naming.TopicName.TRANSACTION_COORDINATOR_LOG;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertTrue;
+import org.apache.pulsar.broker.namespace.NamespaceService;
+import org.apache.pulsar.broker.service.BrokerService;
+import org.apache.pulsar.broker.service.BrokerTestBase;
+import org.apache.pulsar.common.naming.NamespaceName;
import org.apache.pulsar.common.naming.TopicName;
+import org.testng.annotations.AfterMethod;
+import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
-public class SystemTopicClientTest {
+public class SystemTopicClientTest extends BrokerTestBase {
+
+ @Override
+ @BeforeMethod(alwaysRun = true)
+ protected void setup() throws Exception {
+ super.baseSetup();
+ }
+
+ @Override
+ @AfterMethod(alwaysRun = true)
+ protected void cleanup() throws Exception {
+ super.internalCleanup();
+ }
@Test
public void testIsSystemTopic() {
Review comment:
It's better to move this test to `BrokerServiceTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org