[GitHub] [kafka] cmccabe commented on pull request #8916: MINOR; Provide lowest and highest supported versions alongside with the schema in the auto-generated protocol

[GitBox <gi...@apache.org>]

cmccabe commented on pull request #8916:
URL: https://github.com/apache/kafka/pull/8916#issuecomment-657625138


   Yeah, this doesn't need a KIP, as @ijuma said.
   
   @dajac, sorry if this is a silly question, but did you look at the `lowestSupportedVersion` and `highestSupportedVersion` accessor functions that we generate for Message types?  Do those do what you need?
   
   If we need something in static context, where we don't have an instance, I'd prefer something like `ApiMessageType.PRODUCE.highestSupportedVersion()`.  It looks like we don't generate a `lowestSupportedVersion` and `highestSupportedVersion` there, but we could.  I think this would work a bit better with the way we actually tend to use these messages, which is with a type enum in most cases.
   
   I guess if there's a really important use-case then we could add the static variables, though.  So I'm curious what you have in mind...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org