You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/08/07 16:56:12 UTC

Review Request 37220: Upgrades Fail When Calling conf-select On hadoop When hadoop Is Not Installed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37220/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Robert Levas.


Bugs: AMBARI-12676
    https://issues.apache.org/jira/browse/AMBARI-12676


Repository: ambari


Description
-------

When upgrading a host that doesn't have any hadoop component installed, `conf-select` throws an error. This is because we are conf-select'ing when calculating the hadoop_conf directory as part of params. We calculate it regardless of whether it exists.

The fix is to only invoke conf-select when the configuration directory exists.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 9e6adae 
  ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py 4733867 

Diff: https://reviews.apache.org/r/37220/diff/


Testing
-------

Verified on a cluster which has ZK server alone on a single host.

----------------------------------------------------------------------
Total run:786
Total errors:0
Total failures:0
OK


Thanks,

Jonathan Hurley


Re: Review Request 37220: Upgrades Fail When Calling conf-select On hadoop When hadoop Is Not Installed

Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37220/#review94551
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Levas


On Aug. 7, 2015, 10:56 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37220/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2015, 10:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Robert Levas.
> 
> 
> Bugs: AMBARI-12676
>     https://issues.apache.org/jira/browse/AMBARI-12676
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When upgrading a host that doesn't have any hadoop component installed, `conf-select` throws an error. This is because we are conf-select'ing when calculating the hadoop_conf directory as part of params. We calculate it regardless of whether it exists.
> 
> The fix is to only invoke conf-select when the configuration directory exists.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py 9e6adae 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py 4733867 
> 
> Diff: https://reviews.apache.org/r/37220/diff/
> 
> 
> Testing
> -------
> 
> Verified on a cluster which has ZK server alone on a single host.
> 
> ----------------------------------------------------------------------
> Total run:786
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>