You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/06/25 07:27:10 UTC
[PR] test(workflow-operator): add unit test coverage for Sklearn SVM and neighbor classifier descriptors [texera]
aglinxinyuan opened a new pull request, #5945:
URL: https://github.com/apache/texera/pull/5945
### What changes were proposed in this PR?
Pin behavior of four previously-untested Sklearn support-vector and neighbor classifier descriptors in `common/workflow-operator`. No production-code changes.
| Spec | Source class | Tests |
| --- | --- | --- |
| `SklearnSVMOpDescSpec` | `SklearnSVMOpDesc` | 5 |
| `SklearnLinearSVMOpDescSpec` | `SklearnLinearSVMOpDesc` | 5 |
| `SklearnKNNOpDescSpec` | `SklearnKNNOpDesc` | 5 |
| `SklearnNearestCentroidOpDescSpec` | `SklearnNearestCentroidOpDesc` | 5 |
**Behavior pinned**
| Surface | Contract |
| --- | --- |
| `operatorInfo` | exact model name + `Sklearn <name> Operator` description; Sklearn group; training/testing input ports + one blocking output |
| field defaults | `countVectorizer`/`tfidfTransformer` `false`; `target`/`text` `null` |
| `getOutputSchemas` | `model_name` (STRING) + `model` (BINARY) keyed by the declared output port |
| `generatePythonCode` | imports the matching sklearn estimator and builds the `make_pipeline` model |
| Round-trip | config fields preserved through the polymorphic `LogicalOp` base, with the correct `operatorType` discriminator |
### Any related issues, documentation, discussions?
Part of the ongoing `workflow-operator` unit-test coverage effort (follow-up to the Sklearn classifier coverage in #5925, #5939, #5940, #5941).
### How was this PR tested?
- `sbt "WorkflowOperator/testOnly *SklearnSVMOpDescSpec *SklearnLinearSVMOpDescSpec *SklearnKNNOpDescSpec *SklearnNearestCentroidOpDescSpec"` — 20 tests, all green
- `sbt "WorkflowOperator/Test/scalafmtCheck"` and `sbt "WorkflowOperator/scalafixAll --check"` — clean
- CI to confirm
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): add unit test coverage for Sklearn SVM and neighbor classifier descriptors [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 merged PR #5945:
URL: https://github.com/apache/texera/pull/5945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): add unit test coverage for Sklearn SVM and neighbor classifier descriptors [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5945:
URL: https://github.com/apache/texera/pull/5945#issuecomment-4796912635
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 3 worse · ⚪ 12 noise (<±5%) · 0 without baseline
> Compared against main `43ca4b2` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/28154078182)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 390 | 0.238 | 24,055/44,186/44,186 us | 🔴 +37.0% / 🔴 +195.4% |
| ⚪ | bs=100 sw=10 sl=64 | 938 | 0.572 | 106,158/137,656/137,656 us | ⚪ within ±5% / 🔴 +37.3% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,110 | 0.677 | 902,012/960,791/960,791 us | ⚪ within ±5% / ⚪ within ±5% |
<details><summary>Baseline details</summary>
Latest main `43ca4b2` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 390 tuples/sec | 410 tuples/sec | 799.7 tuples/sec | -4.9% | -51.2% |
| bs=10 sw=10 sl=64 | MB/s | 0.238 MB/s | 0.251 MB/s | 0.488 MB/s | -5.2% | -51.2% |
| bs=10 sw=10 sl=64 | p50 | 24,055 us | 24,292 us | 12,125 us | -1.0% | +98.4% |
| bs=10 sw=10 sl=64 | p95 | 44,186 us | 32,260 us | 14,959 us | +37.0% | +195.4% |
| bs=10 sw=10 sl=64 | p99 | 44,186 us | 32,260 us | 18,503 us | +37.0% | +138.8% |
| bs=100 sw=10 sl=64 | throughput | 938 tuples/sec | 946 tuples/sec | 1,069 tuples/sec | -0.8% | -12.2% |
| bs=100 sw=10 sl=64 | MB/s | 0.572 MB/s | 0.577 MB/s | 0.652 MB/s | -0.9% | -12.3% |
| bs=100 sw=10 sl=64 | p50 | 106,158 us | 105,121 us | 92,709 us | +1.0% | +14.5% |
| bs=100 sw=10 sl=64 | p95 | 137,656 us | 135,550 us | 100,227 us | +1.6% | +37.3% |
| bs=100 sw=10 sl=64 | p99 | 137,656 us | 135,550 us | 109,877 us | +1.6% | +25.3% |
| bs=1000 sw=10 sl=64 | throughput | 1,110 tuples/sec | 1,076 tuples/sec | 1,114 tuples/sec | +3.2% | -0.3% |
| bs=1000 sw=10 sl=64 | MB/s | 0.677 MB/s | 0.657 MB/s | 0.68 MB/s | +3.0% | -0.4% |
| bs=1000 sw=10 sl=64 | p50 | 902,012 us | 933,020 us | 899,197 us | -3.3% | +0.3% |
| bs=1000 sw=10 sl=64 | p95 | 960,791 us | 963,889 us | 945,162 us | -0.3% | +1.7% |
| bs=1000 sw=10 sl=64 | p99 | 960,791 us | 963,889 us | 986,231 us | -0.3% | -2.6% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,512.40,200,128000,390,0.238,24054.67,44185.77,44185.77
1,100,10,64,20,2133.18,2000,1280000,938,0.572,106158.32,137656.14,137656.14
2,1000,10,64,20,18018.36,20000,12800000,1110,0.677,902011.95,960791.16,960791.16
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): add unit test coverage for Sklearn SVM and neighbor classifier descriptors [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5945:
URL: https://github.com/apache/texera/pull/5945#issuecomment-4796877683
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): add unit test coverage for Sklearn SVM and neighbor classifier descriptors [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5945:
URL: https://github.com/apache/texera/pull/5945#issuecomment-4796896356
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5945?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.81%. Comparing base ([`43ca4b2`](https://app.codecov.io/gh/apache/texera/commit/43ca4b2c70849af57656bc9a777d0e53f617bcc4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`003fcbd`](https://app.codecov.io/gh/apache/texera/commit/003fcbd4ddf0ce6480a56dbc27b85666070ed6f2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:white_check_mark: All tests successful. No failed tests found.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5945 +/- ##
=========================================
Coverage 54.81% 54.81%
Complexity 2960 2960
=========================================
Files 1115 1115
Lines 43019 43019
Branches 4633 4633
=========================================
Hits 23580 23580
Misses 18056 18056
Partials 1383 1383
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5945/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.36% <ø> (ø)` | | Carriedforward from [43ca4b2](https://app.codecov.io/gh/apache/texera/commit/43ca4b2c70849af57656bc9a777d0e53f617bcc4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.02% <ø> (ø)` | | Carriedforward from [43ca4b2](https://app.codecov.io/gh/apache/texera/commit/43ca4b2c70849af57656bc9a777d0e53f617bcc4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.56% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.02% <ø> (ø)` | | Carriedforward from [43ca4b2](https://app.codecov.io/gh/apache/texera/commit/43ca4b2c70849af57656bc9a777d0e53f617bcc4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <ø> (ø)` | | Carriedforward from [43ca4b2](https://app.codecov.io/gh/apache/texera/commit/43ca4b2c70849af57656bc9a777d0e53f617bcc4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/5945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.20% <ø> (ø)` | | Carriedforward from [43ca4b2](https://app.codecov.io/gh/apache/texera/commit/43ca4b2c70849af57656bc9a777d0e53f617bcc4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.76% <ø> (ø)` | | Carriedforward from [43ca4b2](https://app.codecov.io/gh/apache/texera/commit/43ca4b2c70849af57656bc9a777d0e53f617bcc4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5945/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [43ca4b2](https://app.codecov.io/gh/apache/texera/commit/43ca4b2c70849af57656bc9a777d0e53f617bcc4?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5945?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org