You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Jon Harper (JIRA)" <ji...@apache.org> on 2018/02/01 17:58:00 UTC
[jira] [Commented] (SOLR-9065) Migrate solrj tests from
AbstractDistribZkTestBase to SolrCloudTestCase
[ https://issues.apache.org/jira/browse/SOLR-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349005#comment-16349005 ]
Jon Harper commented on SOLR-9065:
----------------------------------
This patch broke the binary compatibility of solrj's SolrInputDocument class. Before it had a noarg constructor and now it only has the String... constructor. So code compiled against 6.0.1 that does "new SolrInputDocument()" raises NoSuchMethodError when run with version 6.1.0. It's still source compatible so a recompilation of the same source against a newer version will generate the correct constructor call.
I'm not sure if that's important to you, but adding back the no-arg constructor would help when using different dependencies that are compiled against different solrj versions.
Cheers,
Jon
> Migrate solrj tests from AbstractDistribZkTestBase to SolrCloudTestCase
> -----------------------------------------------------------------------
>
> Key: SOLR-9065
> URL: https://issues.apache.org/jira/browse/SOLR-9065
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 6.0, 6.1
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Major
> Attachments: SOLR-9065.patch
>
>
> AbstractDistribZkTestBase sets up collections using the legacy core-based system, and does a lot of comparing things against control collections that the SolrJ tests really don't require. We should migrate these tests to using SolrCloudTestCase instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org