[GitHub] [airflow] potiuk commented on a change in pull request #19918: Fix mypy errors in example DAGs

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #19918:
URL: https://github.com/apache/airflow/pull/19918#discussion_r760132091



##########
File path: airflow/providers/alibaba/cloud/example_dags/example_oss_bucket.py
##########
@@ -14,6 +14,10 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+
+# Ignore mypy argument checking. Some operator args will be passed via ``default_args``.
+# type: ignore[call-arg]

Review comment:
       Yeah. I fully agree we should use the opportunity to improve our type hinting rather than disable it, as our goal is not to pass `mypy` but to get better type hinting and less errors :)
   
   There is a class of errors that can be avoided if we do it  (for example most of the None`s) - that actually hit our users in the recent  months, so  this might have some long-lasting "real-world" consequences. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org