You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Allan Avendaño (JIRA)" <ji...@apache.org> on 2012/07/02 15:19:23 UTC
[jira] [Created] (PIG-2781) LOSort equal method
Allan Avendaño created PIG-2781:
-----------------------------------
Summary: LOSort equal method
Key: PIG-2781
URL: https://issues.apache.org/jira/browse/PIG-2781
Project: Pig
Issue Type: Bug
Components: build
Reporter: Allan Avendaño
Priority: Minor
While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
@Override
public boolean isEqual(Operator other) throws FrontendException {
if (other != null && other instanceof LOSort) {
LOSort otherSort = (LOSort)other;
if (!mAscCols.equals(otherSort.getAscendingCols()))
return false;
if (mSortFunc.equals(otherSort.getUserFunc()))
return false;
if (mIsStar!=otherSort.isStar())
return false;
if (limit!=otherSort.getLimit())
return false;
if (mSortColPlans.equals(otherSort.getSortColPlans()))
return false;
}
return checkEquality((LogicalRelationalOperator)other);
}
if sorting function are equal, it returns false. Also, on the case of same sorting columns plans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2781) LOSort isEqual method
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2781:
----------------------------
Fix Version/s: 0.11
> LOSort isEqual method
> ---------------------
>
> Key: PIG-2781
> URL: https://issues.apache.org/jira/browse/PIG-2781
> Project: Pig
> Issue Type: Bug
> Components: build
> Reporter: Allan Avendaño
> Priority: Minor
> Fix For: 0.11
>
> Attachments: PIG-2781-1.patch
>
>
> While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
> if (mSortFunc.equals(otherSort.getUserFunc()))
> return false;
> ...
> if (mSortColPlans.equals(otherSort.getSortColPlans()))
> return false;
>
> If UDF sorting functions are equal, then it returns false. Also, in the case of same sorting columns plans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2781) LOSort isEqual method
Posted by "Allan Avendaño (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allan Avendaño updated PIG-2781:
--------------------------------
Description:
While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
if (mSortFunc.equals(otherSort.getUserFunc()))
return false;
...
if (mSortColPlans.equals(otherSort.getSortColPlans()))
return false;
if sorting function are equal, it returns false. Also, on the case of same sorting columns plans.
was:
While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
@Override
public boolean isEqual(Operator other) throws FrontendException {
if (other != null && other instanceof LOSort) {
LOSort otherSort = (LOSort)other;
if (!mAscCols.equals(otherSort.getAscendingCols()))
return false;
if (mSortFunc.equals(otherSort.getUserFunc()))
return false;
if (mIsStar!=otherSort.isStar())
return false;
if (limit!=otherSort.getLimit())
return false;
if (mSortColPlans.equals(otherSort.getSortColPlans()))
return false;
}
return checkEquality((LogicalRelationalOperator)other);
}
}
if sorting function are equal, it returns false. Also, on the case of same sorting columns plans.
> LOSort isEqual method
> ---------------------
>
> Key: PIG-2781
> URL: https://issues.apache.org/jira/browse/PIG-2781
> Project: Pig
> Issue Type: Bug
> Components: build
> Reporter: Allan Avendaño
> Priority: Minor
>
> While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
> if (mSortFunc.equals(otherSort.getUserFunc()))
> return false;
> ...
> if (mSortColPlans.equals(otherSort.getSortColPlans()))
> return false;
>
> if sorting function are equal, it returns false. Also, on the case of same sorting columns plans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2781) LOSort isEqual method
Posted by "Allan Avendaño (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allan Avendaño updated PIG-2781:
--------------------------------
Description:
While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
if (mSortFunc.equals(otherSort.getUserFunc()))
return false;
...
if (mSortColPlans.equals(otherSort.getSortColPlans()))
return false;
If UDF sorting functions are equal, then it returns false. Also, in the case of same sorting columns plans.
was:
While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
if (mSortFunc.equals(otherSort.getUserFunc()))
return false;
...
if (mSortColPlans.equals(otherSort.getSortColPlans()))
return false;
if sorting function are equal, it returns false. Also, on the case of same sorting columns plans.
> LOSort isEqual method
> ---------------------
>
> Key: PIG-2781
> URL: https://issues.apache.org/jira/browse/PIG-2781
> Project: Pig
> Issue Type: Bug
> Components: build
> Reporter: Allan Avendaño
> Priority: Minor
>
> While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
> if (mSortFunc.equals(otherSort.getUserFunc()))
> return false;
> ...
> if (mSortColPlans.equals(otherSort.getSortColPlans()))
> return false;
>
> If UDF sorting functions are equal, then it returns false. Also, in the case of same sorting columns plans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PIG-2781) LOSort isEqual method
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy reassigned PIG-2781:
--------------------------------------
Assignee: Allan Avendaño
> LOSort isEqual method
> ---------------------
>
> Key: PIG-2781
> URL: https://issues.apache.org/jira/browse/PIG-2781
> Project: Pig
> Issue Type: Bug
> Components: build
> Reporter: Allan Avendaño
> Assignee: Allan Avendaño
> Priority: Minor
> Fix For: 0.11
>
> Attachments: PIG-2781-1.patch
>
>
> While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
> if (mSortFunc.equals(otherSort.getUserFunc()))
> return false;
> ...
> if (mSortColPlans.equals(otherSort.getSortColPlans()))
> return false;
>
> If UDF sorting functions are equal, then it returns false. Also, in the case of same sorting columns plans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2781) LOSort isEqual method
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2781:
----------------------------
Attachment: PIG-2781-1.patch
That's an obvious bug. Good catch.
> LOSort isEqual method
> ---------------------
>
> Key: PIG-2781
> URL: https://issues.apache.org/jira/browse/PIG-2781
> Project: Pig
> Issue Type: Bug
> Components: build
> Reporter: Allan Avendaño
> Priority: Minor
> Attachments: PIG-2781-1.patch
>
>
> While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
> if (mSortFunc.equals(otherSort.getUserFunc()))
> return false;
> ...
> if (mSortColPlans.equals(otherSort.getSortColPlans()))
> return false;
>
> If UDF sorting functions are equal, then it returns false. Also, in the case of same sorting columns plans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2781) LOSort isEqual method
Posted by "Allan Avendaño (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allan Avendaño updated PIG-2781:
--------------------------------
Summary: LOSort isEqual method (was: LOSort equal method)
> LOSort isEqual method
> ---------------------
>
> Key: PIG-2781
> URL: https://issues.apache.org/jira/browse/PIG-2781
> Project: Pig
> Issue Type: Bug
> Components: build
> Reporter: Allan Avendaño
> Priority: Minor
>
> While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
> @Override
> public boolean isEqual(Operator other) throws FrontendException {
> if (other != null && other instanceof LOSort) {
> LOSort otherSort = (LOSort)other;
> if (!mAscCols.equals(otherSort.getAscendingCols()))
> return false;
> if (mSortFunc.equals(otherSort.getUserFunc()))
> return false;
> if (mIsStar!=otherSort.isStar())
> return false;
> if (limit!=otherSort.getLimit())
> return false;
> if (mSortColPlans.equals(otherSort.getSortColPlans()))
> return false;
> }
> return checkEquality((LogicalRelationalOperator)other);
> }
> if sorting function are equal, it returns false. Also, on the case of same sorting columns plans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2781) LOSort isEqual method
Posted by "Allan Avendaño (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allan Avendaño updated PIG-2781:
--------------------------------
Description:
While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
@Override
public boolean isEqual(Operator other) throws FrontendException {
if (other != null && other instanceof LOSort) {
LOSort otherSort = (LOSort)other;
if (!mAscCols.equals(otherSort.getAscendingCols()))
return false;
if (mSortFunc.equals(otherSort.getUserFunc()))
return false;
if (mIsStar!=otherSort.isStar())
return false;
if (limit!=otherSort.getLimit())
return false;
if (mSortColPlans.equals(otherSort.getSortColPlans()))
return false;
}
return checkEquality((LogicalRelationalOperator)other);
}
if sorting function are equal, it returns false. Also, on the case of same sorting columns plans.
was:
While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
@Override
public boolean isEqual(Operator other) throws FrontendException {
if (other != null && other instanceof LOSort) {
LOSort otherSort = (LOSort)other;
if (!mAscCols.equals(otherSort.getAscendingCols()))
return false;
if (mSortFunc.equals(otherSort.getUserFunc()))
return false;
if (mIsStar!=otherSort.isStar())
return false;
if (limit!=otherSort.getLimit())
return false;
if (mSortColPlans.equals(otherSort.getSortColPlans()))
return false;
}
return checkEquality((LogicalRelationalOperator)other);
}
if sorting function are equal, it returns false. Also, on the case of same sorting columns plans.
> LOSort isEqual method
> ---------------------
>
> Key: PIG-2781
> URL: https://issues.apache.org/jira/browse/PIG-2781
> Project: Pig
> Issue Type: Bug
> Components: build
> Reporter: Allan Avendaño
> Priority: Minor
>
> While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
> @Override
> public boolean isEqual(Operator other) throws FrontendException {
> if (other != null && other instanceof LOSort) {
> LOSort otherSort = (LOSort)other;
> if (!mAscCols.equals(otherSort.getAscendingCols()))
> return false;
> if (mSortFunc.equals(otherSort.getUserFunc()))
> return false;
> if (mIsStar!=otherSort.isStar())
> return false;
> if (limit!=otherSort.getLimit())
> return false;
> if (mSortColPlans.equals(otherSort.getSortColPlans()))
> return false;
> }
> return checkEquality((LogicalRelationalOperator)other);
> }
> if sorting function are equal, it returns false. Also, on the case of same sorting columns plans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2781) LOSort isEqual method
Posted by "Allan Avendaño (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allan Avendaño updated PIG-2781:
--------------------------------
Description:
While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
@Override
public boolean isEqual(Operator other) throws FrontendException {
if (other != null && other instanceof LOSort) {
LOSort otherSort = (LOSort)other;
if (!mAscCols.equals(otherSort.getAscendingCols()))
return false;
if (mSortFunc.equals(otherSort.getUserFunc()))
return false;
if (mIsStar!=otherSort.isStar())
return false;
if (limit!=otherSort.getLimit())
return false;
if (mSortColPlans.equals(otherSort.getSortColPlans()))
return false;
}
return checkEquality((LogicalRelationalOperator)other);
}
}
if sorting function are equal, it returns false. Also, on the case of same sorting columns plans.
was:
While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
@Override
public boolean isEqual(Operator other) throws FrontendException {
if (other != null && other instanceof LOSort) {
LOSort otherSort = (LOSort)other;
if (!mAscCols.equals(otherSort.getAscendingCols()))
return false;
if (mSortFunc.equals(otherSort.getUserFunc()))
return false;
if (mIsStar!=otherSort.isStar())
return false;
if (limit!=otherSort.getLimit())
return false;
if (mSortColPlans.equals(otherSort.getSortColPlans()))
return false;
}
return checkEquality((LogicalRelationalOperator)other);
}
if sorting function are equal, it returns false. Also, on the case of same sorting columns plans.
> LOSort isEqual method
> ---------------------
>
> Key: PIG-2781
> URL: https://issues.apache.org/jira/browse/PIG-2781
> Project: Pig
> Issue Type: Bug
> Components: build
> Reporter: Allan Avendaño
> Priority: Minor
>
> While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
> @Override
> public boolean isEqual(Operator other) throws FrontendException {
> if (other != null && other instanceof LOSort) {
> LOSort otherSort = (LOSort)other;
> if (!mAscCols.equals(otherSort.getAscendingCols()))
> return false;
> if (mSortFunc.equals(otherSort.getUserFunc()))
> return false;
> if (mIsStar!=otherSort.isStar())
> return false;
> if (limit!=otherSort.getLimit())
> return false;
> if (mSortColPlans.equals(otherSort.getSortColPlans()))
> return false;
> }
> return checkEquality((LogicalRelationalOperator)other);
> }
> }
> if sorting function are equal, it returns false. Also, on the case of same sorting columns plans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2781) LOSort isEqual method
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitriy V. Ryaboy updated PIG-2781:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to trunk.
Thanks for pointing this out, Allan.
> LOSort isEqual method
> ---------------------
>
> Key: PIG-2781
> URL: https://issues.apache.org/jira/browse/PIG-2781
> Project: Pig
> Issue Type: Bug
> Components: build
> Reporter: Allan Avendaño
> Assignee: Allan Avendaño
> Priority: Minor
> Fix For: 0.11
>
> Attachments: PIG-2781-1.patch
>
>
> While I was checking the logical operators, I found that LOSort does this while comparing two logical operators:
> if (mSortFunc.equals(otherSort.getUserFunc()))
> return false;
> ...
> if (mSortColPlans.equals(otherSort.getSortColPlans()))
> return false;
>
> If UDF sorting functions are equal, then it returns false. Also, in the case of same sorting columns plans.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira