You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "sebbASF (via GitHub)" <gi...@apache.org> on 2023/10/28 22:54:36 UTC
[PR] Unnecessary profiles; use -Dtarget.name instead [commons-crypto]
sebbASF opened a new pull request, #263:
URL: https://github.com/apache/commons-crypto/pull/263
These profiles just clutter the pom.
in any case, they don't cover all possible target names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unnecessary profiles; use -Dtarget.name instead [commons-crypto]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF merged PR #263:
URL: https://github.com/apache/commons-crypto/pull/263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unnecessary profiles; use -Dtarget.name instead [commons-crypto]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #263:
URL: https://github.com/apache/commons-crypto/pull/263#issuecomment-1788588785
Looks like at least one profile may need an additional property override. See #264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unnecessary profiles; use -Dtarget.name instead [commons-crypto]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #263:
URL: https://github.com/apache/commons-crypto/pull/263#issuecomment-1793389523
It does seem to be possible to detect a specific value of target.name and use that to define another property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unnecessary profiles; use -Dtarget.name instead [commons-crypto]
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #263:
URL: https://github.com/apache/commons-crypto/pull/263#issuecomment-1788648534
It seems one may be able to automatically activate a profile based on a property.
If so, it should be possible to automatically change another property based on matching the value of target.name. To be investigated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Unnecessary profiles; use -Dtarget.name instead [commons-crypto]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #263:
URL: https://github.com/apache/commons-crypto/pull/263#issuecomment-1783937438
We're currently processing your upload. This comment will be updated when the results are available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org