You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2026/09/12 22:28:44 UTC
[XL] Change in asterixdb[master]: [ASTERIXDB-3838][EXT]: Shadow PrefixedStorage
From Hussain Towaileb <hu...@gmail.com>:
Hussain Towaileb has uploaded a new patch set (#2). ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21770?usp=email )
Change subject: [ASTERIXDB-3838][EXT]: Shadow PrefixedStorage
......................................................................
[ASTERIXDB-3838][EXT]: Shadow PrefixedStorage
An alternative to the parent change rather than a follow-up to it: keep
the copy in org.apache.iceberg.gcp.gcs instead of repackaging it, so
package-private access still works against the real iceberg-gcp jar and
only the one class we actually modify has to exist here.
Nine of the ten forked files go away, and with them both
AnalyticsCoreUtil omissions and the serialVersionUID.
AnalyticsCoreUtil's signatures mention only AutoCloseable, BlobId, Map
and MetricsContext, so PrefixedStorage compiles against it with no
gcs-analytics-core on the class path, and GCSFileIO is upstream's again.
Verified at runtime rather than by inspection: an instrumented build
showed credentials() entered five times taking the terminal branch, and
all five GCS authentication types pass end to end, with the isolation
probe refusing both the wrong-credentials and the no-credentials arms
while the valid one reads.
The cbas-core change on this topic makes the shadow win the class-path
race deliberately rather than alphabetically, and the installer
footprint fixture fails if that jar ever stops being produced.
Ext-ref: MB-73557, MB-73934
Co-Authored-By: Claude Opus 5 <no...@anthropic.com>
Change-Id: Ib08a39bd4bc43e2928124fac1dd54b6ea002c1c5
---
D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/BaseGCSFile.java
D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSExceptionUtil.java
D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSFileIO.java
D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSInputFile.java
D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSInputStream.java
D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSLocation.java
D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSOutputFile.java
D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/GCSOutputStream.java
D asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/google/iceberg/fileio/OAuth2RefreshCredentialsHandler.java
M asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/iceberg/IcebergUtils.java
R asterixdb/asterix-external-data/src/main/java/org/apache/iceberg/gcp/gcs/PrefixedStorage.java
M asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/util/iceberg/IcebergVendedCredentialsTest.java
12 files changed, 25 insertions(+), 1,198 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/70/21770/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/21770?usp=email
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ib08a39bd4bc43e2928124fac1dd54b6ea002c1c5
Gerrit-Change-Number: 21770
Gerrit-PatchSet: 2
Gerrit-Owner: Hussain Towaileb <hu...@gmail.com>
Gerrit-CC: Jenkins <je...@fulliautomatix.ics.uci.edu>