You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "akzarma (via GitHub)" <gi...@apache.org> on 2023/04/06 12:27:35 UTC
[GitHub] [superset] akzarma opened a new pull request, #23611: fix(saved_queries) wrong enum for object_type of saved_query
akzarma opened a new pull request, #23611:
URL: https://github.com/apache/superset/pull/23611
### SUMMARY
Fixes #23610
There is no "saved_query" enum value of object_type for saved queries as such. it should be "query" instead as it can be seen in ObjectTypes class.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1509" alt="Screenshot 2023-04-06 at 4 51 32 PM" src="https://user-images.githubusercontent.com/25038017/230378106-e1bd5b2a-cc5d-40e7-9fe9-c9e0c4d49f51.png">
### TESTING INSTRUCTIONS
1. Setup Postgres as backend db (as the default sqlite db doesn't really strictly checks the enum type of object_type)
2. Go to "Saved queries" page
3. The list should load fine.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #23610
- [ ] Required feature flags: TAGGING_SYSTEM
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23611: fix(saved_queries): wrong enum for object_type of saved_query
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23611:
URL: https://github.com/apache/superset/pull/23611#issuecomment-1499000346
## [Codecov](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23611](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ed9eec) into [master](https://codecov.io/gh/apache/superset/commit/c5eecc7cc2da88b367bfc7636edb52e0ba117bae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5eecc7) will **decrease** coverage by `11.34%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4ed9eec differs from pull request most recent head 45698a5. Consider uploading reports for the commit 45698a5 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23611 +/- ##
===========================================
- Coverage 67.72% 56.38% -11.34%
===========================================
Files 1916 1916
Lines 74051 74051
Branches 8040 8040
===========================================
- Hits 50153 41757 -8396
- Misses 21850 30246 +8396
Partials 2048 2048
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.68% <ø> (ø)` | |
| python | `58.97% <ø> (-23.45%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.64% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/components/Datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9DaGFuZ2VEYXRhc291cmNlTW9kYWwudHN4) | `78.68% <ø> (ø)` | |
| [...ponents/ReportModal/HeaderReportDropdown/index.tsx](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUmVwb3J0TW9kYWwvSGVhZGVyUmVwb3J0RHJvcGRvd24vaW5kZXgudHN4) | `67.50% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.tsx](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC50c3g=) | `64.03% <ø> (ø)` | |
| [...d/src/explore/components/PropertiesModal/index.tsx](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwvaW5kZXgudHN4) | `50.53% <ø> (ø)` | |
| [...erset-frontend/src/pages/AlertReportList/index.tsx](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0FsZXJ0UmVwb3J0TGlzdC9pbmRleC50c3g=) | `59.64% <ø> (ø)` | |
| [superset-frontend/src/pages/AllEntities/index.tsx](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0FsbEVudGl0aWVzL2luZGV4LnRzeA==) | `0.00% <ø> (ø)` | |
| [...t-frontend/src/pages/AnnotationLayerList/index.tsx](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0Fubm90YXRpb25MYXllckxpc3QvaW5kZXgudHN4) | `68.05% <ø> (ø)` | |
| [...perset-frontend/src/pages/AnnotationList/index.tsx](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0Fubm90YXRpb25MaXN0L2luZGV4LnRzeA==) | `69.35% <ø> (ø)` | |
| [superset-frontend/src/pages/ChartList/index.tsx](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0NoYXJ0TGlzdC9pbmRleC50c3g=) | `55.31% <ø> (ø)` | |
| [...erset-frontend/src/pages/CssTemplateList/index.tsx](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0Nzc1RlbXBsYXRlTGlzdC9pbmRleC50c3g=) | `66.66% <ø> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/superset/pull/23611?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [356 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23611/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez merged pull request #23611: fix(saved_queries): wrong enum for object_type of saved_query
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez merged PR #23611:
URL: https://github.com/apache/superset/pull/23611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org