You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by James Carman <ja...@carmanconsulting.com> on 2010/03/25 20:39:22 UTC
ListMultipleChoice's Constructor?
It takes IModel<Collection<T>>. Shouldn't it take IModel<? extends
Collection<T>>? This is for the model for the thing that it's
editing.
Re: ListMultipleChoice's Constructor?
Posted by James Carman <jc...@carmanconsulting.com>.
I've attached a patch against trunk to the following issue:
https://issues.apache.org/jira/browse/WICKET-2803
I would assume that patch can be applied to the branch with no issues, since
ListMultipleChoice didn't move or anything and it's really quite a minimal
change.
On Thu, Mar 25, 2010 at 9:22 PM, James Carman
<jc...@carmanconsulting.com>wrote:
> I suppose you want it against the 1.4 branch and trunk both? Or, will you
> merge it up from the branch?
>
>
> On Thu, Mar 25, 2010 at 7:47 PM, James Carman <
> jcarman@carmanconsulting.com> wrote:
>
>> I'm sure I can whip one up pretty quickly. I can't believe I missed it
>> during my first round of clean-ups like this
>>
>>
>> On Thu, Mar 25, 2010 at 5:06 PM, Igor Vaynberg <ig...@gmail.com>wrote:
>>
>>> got a patch that compiles and does not break backwards compat?
>>>
>>> -igor
>>>
>>> On Thu, Mar 25, 2010 at 12:39 PM, James Carman
>>> <ja...@carmanconsulting.com> wrote:
>>> > It takes IModel<Collection<T>>. Shouldn't it take IModel<? extends
>>> > Collection<T>>? This is for the model for the thing that it's
>>> > editing.
>>> >
>>>
>>
>>
>
Re: ListMultipleChoice's Constructor?
Posted by James Carman <jc...@carmanconsulting.com>.
I suppose you want it against the 1.4 branch and trunk both? Or, will you
merge it up from the branch?
On Thu, Mar 25, 2010 at 7:47 PM, James Carman
<jc...@carmanconsulting.com>wrote:
> I'm sure I can whip one up pretty quickly. I can't believe I missed it
> during my first round of clean-ups like this
>
>
> On Thu, Mar 25, 2010 at 5:06 PM, Igor Vaynberg <ig...@gmail.com>wrote:
>
>> got a patch that compiles and does not break backwards compat?
>>
>> -igor
>>
>> On Thu, Mar 25, 2010 at 12:39 PM, James Carman
>> <ja...@carmanconsulting.com> wrote:
>> > It takes IModel<Collection<T>>. Shouldn't it take IModel<? extends
>> > Collection<T>>? This is for the model for the thing that it's
>> > editing.
>> >
>>
>
>
Re: ListMultipleChoice's Constructor?
Posted by James Carman <jc...@carmanconsulting.com>.
I'm sure I can whip one up pretty quickly. I can't believe I missed it
during my first round of clean-ups like this
On Thu, Mar 25, 2010 at 5:06 PM, Igor Vaynberg <ig...@gmail.com>wrote:
> got a patch that compiles and does not break backwards compat?
>
> -igor
>
> On Thu, Mar 25, 2010 at 12:39 PM, James Carman
> <ja...@carmanconsulting.com> wrote:
> > It takes IModel<Collection<T>>. Shouldn't it take IModel<? extends
> > Collection<T>>? This is for the model for the thing that it's
> > editing.
> >
>
Re: ListMultipleChoice's Constructor?
Posted by Igor Vaynberg <ig...@gmail.com>.
got a patch that compiles and does not break backwards compat?
-igor
On Thu, Mar 25, 2010 at 12:39 PM, James Carman
<ja...@carmanconsulting.com> wrote:
> It takes IModel<Collection<T>>. Shouldn't it take IModel<? extends
> Collection<T>>? This is for the model for the thing that it's
> editing.
>