You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Ed Burns <ed...@sun.com> on 2006/04/04 16:04:21 UTC
FacesServlet final/non-final
Hello MyFaces developers,
It has come to my attention that several people have complained about
the FacesServlet class moving from being non-final to being
final. [1][2][3]
I just wanted to set the record straight on this point.
According to the JSF 1.0 spec, the class has always been final. [4] I
contrasted this with svn revision 166408 of FacesServlet.java from
MyFaces and found that it was not final. Therefore, I conclude that
this issue was a bug that has been fixed in the MyFaces impl.
We now return you to your regularly scheduled discussion.
Ed
[1]
http://mail-archives.apache.org/mod_mbox/myfaces-dev/200509.mbox/%3cB17B1CFF4282214AB8BAADDDC20711220467BFC3@THHS2EXBE1X.hostedservice2.net%3e
[2]
http://mail-archives.apache.org/mod_mbox/myfaces-dev/200509.mbox/%3c5a99335f0509190317c492d92@mail.gmail.com%3e
[3]
http://www.jroller.com/page/ksevindik?entry=uncaught_exception_handling_in_java
[4] http://fisheye5.cenqua.com/viewrep/javaserverfaces-sources/jsf-api/src/javax/faces/webapp/FacesServlet.java#r1.1
--
| ed.burns@sun.com | {home: 407 869 9587, office: 408 884 9519 OR x31640}
| homepage: | http://purl.oclc.org/NET/edburns/
| aim: edburns0sunw | iim: ed.burns@sun.com
| 30 Business Days until JavaOne SF 2006
Re: FacesServlet final/non-final
Posted by Adam Winer <aw...@gmail.com>.
There's not enough code in it to warrant subclassing; filters
and servlets that forward are a far better way to attach additional
behaviors. Plus, some code that uses the existence of FacesServlet
in WEB-INF/web.xml would have done poorly.
-- Adam
On 4/4/06, Martin Marinschek <ma...@gmail.com> wrote:
> Yes, you're right.
>
> Fixed bug in MyFaces.
>
> May I ask you why the FacesServlet was originally crafted as being final?
>
> regards,
>
> Martin
>
> On 4/4/06, Ed Burns <ed...@sun.com> wrote:
> > Hello MyFaces developers,
> >
> > It has come to my attention that several people have complained about
> > the FacesServlet class moving from being non-final to being
> > final. [1][2][3]
> >
> > I just wanted to set the record straight on this point.
> >
> > According to the JSF 1.0 spec, the class has always been final. [4] I
> > contrasted this with svn revision 166408 of FacesServlet.java from
> > MyFaces and found that it was not final. Therefore, I conclude that
> > this issue was a bug that has been fixed in the MyFaces impl.
> >
> > We now return you to your regularly scheduled discussion.
> >
> > Ed
> >
> > [1]
> > http://mail-archives.apache.org/mod_mbox/myfaces-dev/200509.mbox/%3cB17B1CFF4282214AB8BAADDDC20711220467BFC3@THHS2EXBE1X.hostedservice2.net%3e
> > [2]
> > http://mail-archives.apache.org/mod_mbox/myfaces-dev/200509.mbox/%3c5a99335f0509190317c492d92@mail.gmail.com%3e
> > [3]
> > http://www.jroller.com/page/ksevindik?entry=uncaught_exception_handling_in_java
> >
> > [4] http://fisheye5.cenqua.com/viewrep/javaserverfaces-sources/jsf-api/src/javax/faces/webapp/FacesServlet.java#r1.1
> >
> > --
> > | ed.burns@sun.com | {home: 407 869 9587, office: 408 884 9519 OR x31640}
> > | homepage: | http://purl.oclc.org/NET/edburns/
> > | aim: edburns0sunw | iim: ed.burns@sun.com
> > | 30 Business Days until JavaOne SF 2006
> >
> >
>
>
> --
>
> http://www.irian.at
>
> Your JSF powerhouse -
> JSF Consulting, Development and
> Courses in English and German
>
> Professional Support for Apache MyFaces
>
Re: FacesServlet final/non-final
Posted by Martin Marinschek <ma...@gmail.com>.
Yes, you're right.
Fixed bug in MyFaces.
May I ask you why the FacesServlet was originally crafted as being final?
regards,
Martin
On 4/4/06, Ed Burns <ed...@sun.com> wrote:
> Hello MyFaces developers,
>
> It has come to my attention that several people have complained about
> the FacesServlet class moving from being non-final to being
> final. [1][2][3]
>
> I just wanted to set the record straight on this point.
>
> According to the JSF 1.0 spec, the class has always been final. [4] I
> contrasted this with svn revision 166408 of FacesServlet.java from
> MyFaces and found that it was not final. Therefore, I conclude that
> this issue was a bug that has been fixed in the MyFaces impl.
>
> We now return you to your regularly scheduled discussion.
>
> Ed
>
> [1]
> http://mail-archives.apache.org/mod_mbox/myfaces-dev/200509.mbox/%3cB17B1CFF4282214AB8BAADDDC20711220467BFC3@THHS2EXBE1X.hostedservice2.net%3e
> [2]
> http://mail-archives.apache.org/mod_mbox/myfaces-dev/200509.mbox/%3c5a99335f0509190317c492d92@mail.gmail.com%3e
> [3]
> http://www.jroller.com/page/ksevindik?entry=uncaught_exception_handling_in_java
>
> [4] http://fisheye5.cenqua.com/viewrep/javaserverfaces-sources/jsf-api/src/javax/faces/webapp/FacesServlet.java#r1.1
>
> --
> | ed.burns@sun.com | {home: 407 869 9587, office: 408 884 9519 OR x31640}
> | homepage: | http://purl.oclc.org/NET/edburns/
> | aim: edburns0sunw | iim: ed.burns@sun.com
> | 30 Business Days until JavaOne SF 2006
>
>
--
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces