You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/09 04:12:38 UTC

[GitHub] [spark] viirya commented on a change in pull request #35432: [SPARK-37585][SQL] Update InputMetric in DataSourceRDD with TaskCompletionListener

viirya commented on a change in pull request #35432:
URL: https://github.com/apache/spark/pull/35432#discussion_r802254113



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/DataSourceScanExecRedactionSuite.scala
##########
@@ -244,4 +244,33 @@ class DataSourceV2ScanExecRedactionSuite extends DataSourceScanRedactionTest {
       }
     }
   }
+
+  test("SPARK-37585: test input metrics for DSV2 with output limits") {

Review comment:
       don't you have only one new test? any other related tests?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org