You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/24 16:21:52 UTC

[GitHub] [spark] LuciferYang commented on a diff in pull request #38370: [SPARK-40898][SQL] Quote function names in datatype mismatch errors

LuciferYang commented on code in PR #38370:
URL: https://github.com/apache/spark/pull/38370#discussion_r1003513226


##########
sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out:
##########
@@ -3609,7 +3609,7 @@ org.apache.spark.sql.AnalysisException
   "errorClass" : "DATATYPE_MISMATCH.DATA_DIFF_TYPES",
   "messageParameters" : {
     "dataType" : "(\"INTERVAL MONTH\" or \"INTERVAL DAY\")",
-    "functionName" : "function array",
+    "functionName" : "`function array`",

Review Comment:
   Should it be `function `array``?
   
   



##########
sql/core/src/test/resources/sql-tests/results/ansi/interval.sql.out:
##########
@@ -3609,7 +3609,7 @@ org.apache.spark.sql.AnalysisException
   "errorClass" : "DATATYPE_MISMATCH.DATA_DIFF_TYPES",
   "messageParameters" : {
     "dataType" : "(\"INTERVAL MONTH\" or \"INTERVAL DAY\")",
-    "functionName" : "function array",
+    "functionName" : "`function array`",

Review Comment:
   Should it be `function \`array\``?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org