You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/10/21 21:37:11 UTC

[GitHub] [systemds] ywcb00 opened a new pull request #1419: [SYSTEMDS-3125] Verify Federated Output

ywcb00 opened a new pull request #1419:
URL: https://github.com/apache/systemds/pull/1419


   Hi,
   This PR adds a few checks to the primitve function tests to ensure that the output is federated.
   I always verified it by simply adding an additional instruction (uak+) - which is then executed federated - and checking that the heavy hitters contain this specific federated instruction (fed_uak+).
   
   Thanks for review :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] mboehm7 commented on pull request #1419: [SYSTEMDS-3125] Verify Federated Output

Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1419:
URL: https://github.com/apache/systemds/pull/1419#issuecomment-997280424


   LGTM - thanks for the patch @ywcb00. During merge I only made a minor modification in the `FederatedWeightedDivMatrixMultTest` test to use our util `CollectionUtils.asSet`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [systemds] asfgit closed pull request #1419: [SYSTEMDS-3125] Verify Federated Output

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1419:
URL: https://github.com/apache/systemds/pull/1419


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org