[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2569: Single node prop store refactor

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #2569:
URL: https://github.com/apache/accumulo/pull/2569#discussion_r869672631


##########
server/manager/src/main/java/org/apache/accumulo/manager/ManagerClientServiceHandler.java:
##########
@@ -397,21 +399,25 @@ private void alterNamespaceProperty(TCredentials c, String namespace, String pro
 
     try {
       if (value == null) {
-        NamespacePropUtil.removeNamespaceProperty(manager.getContext(), namespaceId, property);
+        NamespacePropUtil.factory().removeProperties(manager.getContext(), namespaceId,
+            List.of(property));
       } else {
-        NamespacePropUtil.setNamespaceProperty(manager.getContext(), namespaceId, property, value);
+        NamespacePropUtil.factory().setProperties(manager.getContext(), namespaceId,
+            Map.of(property, value));
+      }
+    } catch (PropStoreException ex) {
+      if (ex.getCause() instanceof KeeperException.NoNodeException) {

Review Comment:
   I think they should always be one level deep for this case. If it wasn't, we might want to handle it completely differently.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org