You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/03 06:26:25 UTC

[GitHub] [shardingsphere] CreatureOX opened a new pull request #12190: remove out-of-date description in hint.cn.md and hint.en.md

CreatureOX opened a new pull request #12190:
URL: https://github.com/apache/shardingsphere/pull/12190


   Fixes #12182.
   
   Changes proposed in this pull request:
   - Remove out-of-date description about hint
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] CreatureOX commented on a change in pull request #12190: remove out-of-date description in hint.cn.md and hint.en.md

Posted by GitBox <gi...@apache.org>.
CreatureOX commented on a change in pull request #12190:
URL: https://github.com/apache/shardingsphere/pull/12190#discussion_r701643971



##########
File path: docs/document/content/user-manual/shardingsphere-jdbc/usage/sharding/hint.cn.md
##########
@@ -57,9 +57,6 @@ HintManager hintManager = HintManager.getInstance();
 - 使用 `hintManager.addDatabaseShardingValue` 来添加数据源分片键值。
 - 使用 `hintManager.addTableShardingValue` 来添加表分片键值。
 
-> 分库不分表情况下，强制路由至某一个分库时，可使用 `hintManager.setDatabaseShardingValue` 方式添加分片。

Review comment:
       I see. I will keep the first line.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #12190: remove out-of-date description in hint.cn.md and hint.en.md

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on a change in pull request #12190:
URL: https://github.com/apache/shardingsphere/pull/12190#discussion_r701638022



##########
File path: docs/document/content/user-manual/shardingsphere-jdbc/usage/sharding/hint.cn.md
##########
@@ -57,9 +57,6 @@ HintManager hintManager = HintManager.getInstance();
 - 使用 `hintManager.addDatabaseShardingValue` 来添加数据源分片键值。
 - 使用 `hintManager.addTableShardingValue` 来添加表分片键值。
 
-> 分库不分表情况下，强制路由至某一个分库时，可使用 `hintManager.setDatabaseShardingValue` 方式添加分片。

Review comment:
       The first line should not be removed, `hintManager.setDatabaseShardingValue` is working now.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss merged pull request #12190: remove out-of-date description in hint.cn.md and hint.en.md

Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #12190:
URL: https://github.com/apache/shardingsphere/pull/12190


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] CreatureOX commented on a change in pull request #12190: remove out-of-date description in hint.cn.md and hint.en.md

Posted by GitBox <gi...@apache.org>.
CreatureOX commented on a change in pull request #12190:
URL: https://github.com/apache/shardingsphere/pull/12190#discussion_r701643971



##########
File path: docs/document/content/user-manual/shardingsphere-jdbc/usage/sharding/hint.cn.md
##########
@@ -57,9 +57,6 @@ HintManager hintManager = HintManager.getInstance();
 - 使用 `hintManager.addDatabaseShardingValue` 来添加数据源分片键值。
 - 使用 `hintManager.addTableShardingValue` 来添加表分片键值。
 
-> 分库不分表情况下，强制路由至某一个分库时，可使用 `hintManager.setDatabaseShardingValue` 方式添加分片。

Review comment:
       Got it. I will keep the first line.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org