[airflow] branch main updated: Refactor: added type annotation (#16668)

[po...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new 9d24863  Refactor: added type annotation (#16668)
9d24863 is described below

commit 9d248630e8f4f7ba74c932db6e3e06dff73d9190
Author: Ali Muhammad <al...@gmail.com>
AuthorDate: Sun Jun 27 23:14:19 2021 +0500

    Refactor: added type annotation (#16668)
---
 tests/build_provider_packages_dependencies.py | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/tests/build_provider_packages_dependencies.py b/tests/build_provider_packages_dependencies.py
index 1e7bdbc..668c0c9 100644
--- a/tests/build_provider_packages_dependencies.py
+++ b/tests/build_provider_packages_dependencies.py
@@ -20,15 +20,15 @@ import sys
 from ast import Import, ImportFrom, NodeVisitor, parse
 from collections import defaultdict
 from os.path import dirname, sep
-from typing import Dict, List, Optional
+from typing import Dict, List, Optional, Tuple
 
 from setup import PROVIDERS_REQUIREMENTS
 
 sys.path.append(os.path.join(dirname(__file__), os.pardir))
 
 
-AIRFLOW_PROVIDERS_FILE_PREFIX = "airflow" + sep + "providers" + sep
-AIRFLOW_TESTS_PROVIDERS_FILE_PREFIX = "tests" + sep + "providers" + sep
+AIRFLOW_PROVIDERS_FILE_PREFIX = f"airflow{sep}providers{sep}"
+AIRFLOW_TESTS_PROVIDERS_FILE_PREFIX = f"tests{sep}providers{sep}"
 AIRFLOW_PROVIDERS_IMPORT_PREFIX = "airflow.providers."
 
 # List of information messages generated
@@ -84,7 +84,7 @@ def get_provider_from_file_name(file_name: str) -> Optional[str]:
     return provider
 
 
-def get_file_suffix(file_name):
+def get_file_suffix(file_name) -> Optional[str]:
     if AIRFLOW_PROVIDERS_FILE_PREFIX in file_name:
         return file_name[file_name.find(AIRFLOW_PROVIDERS_FILE_PREFIX) :]
     if AIRFLOW_TESTS_PROVIDERS_FILE_PREFIX in file_name:
@@ -114,13 +114,13 @@ class ImportFinder(NodeVisitor):
     AST visitor that collects all imported names in its imports
     """
 
-    def __init__(self, filename):
+    def __init__(self, filename: str) -> None:
         self.imports: List[str] = []
         self.filename = filename
         self.handled_import_exception = List[str]
         self.tried_imports: List[str] = []
 
-    def process_import(self, import_name: str):
+    def process_import(self, import_name: str) -> None:
         self.imports.append(import_name)
 
     def get_import_name_from_import_from(self, node: ImportFrom) -> List[str]:  # noqa
@@ -136,11 +136,11 @@ class ImportFinder(NodeVisitor):
             import_names.append(fullname)
         return import_names
 
-    def visit_Import(self, node: Import):  # pylint: disable=invalid-name
+    def visit_Import(self, node: Import) -> None:  # pylint: disable=invalid-name
         for alias in node.names:
             self.process_import(alias.name)
 
-    def visit_ImportFrom(self, node: ImportFrom):  # pylint: disable=invalid-name
+    def visit_ImportFrom(self, node: ImportFrom) -> None:  # pylint: disable=invalid-name
         if node.module == '__future__':
             return
         for fullname in self.get_import_name_from_import_from(node):
@@ -164,7 +164,7 @@ def get_imports_from_file(file_name: str) -> List[str]:
     return visitor.imports
 
 
-def check_if_different_provider_used(file_name: str):
+def check_if_different_provider_used(file_name: str) -> None:
     file_provider = get_provider_from_file_name(file_name)
     if not file_provider:
         return
@@ -175,7 +175,7 @@ def check_if_different_provider_used(file_name: str):
             dependencies[file_provider].append(import_provider)
 
 
-def parse_arguments():
+def parse_arguments() -> Tuple[str, str, str]:
     import argparse
 
     parser = argparse.ArgumentParser(
@@ -209,7 +209,7 @@ FOOTER = """========================== ===========================
 """
 
 
-def insert_documentation(deps_dict: Dict[str, List[str]], res: List[str]):
+def insert_documentation(deps_dict: Dict[str, List[str]], res: List[str]) -> None:
     res += HEADER.splitlines(keepends=True)
     for package, deps in deps_dict.items():
         deps_str = ",".join(deps)